feat: allow setting PersistentVolumeClaimRetentionPolicy#252
Open
ed-marks wants to merge 2 commits intoakyriako:mainfrom
Open
feat: allow setting PersistentVolumeClaimRetentionPolicy#252ed-marks wants to merge 2 commits intoakyriako:mainfrom
ed-marks wants to merge 2 commits intoakyriako:mainfrom
Conversation
Owner
|
Hi @ed-marks thanks for the PR. Dont worry about the |
ed-marks
force-pushed
the
ed/pvc-retention
branch
from
1fa4608 to
2e3d46f
Compare
Author
Nice one thank you - I've made the rename, I'll see about manually testing it this week to make sure i've not missed anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring StatefulSet PVC retention via
spec.storage.persistentVolumeClaimRetentionPolicyonTypesenseCluster.This lets you control what happens to PVCs on scale-down or cluster deletion (Retain/Delete) by wiring the CRD field through to the generated StatefulSet. I've added to the base sample what that looks like.
The main use case for me is short-lived test clusters, where PVCs should be cleaned up automatically when clusters are torn down, while still leaving production-like defaults.
I also noticed the local kind cluster was named incorrectly and there was a suspect OR condition flagged by
go vetwhich always evaluated to true. I believe it was mean to be "whencondition.Reasonis neitherConditionReasonQuorumDowngradedorConditionReasonQuorumQueuedWrites" which is what i've amended it to.Also mostly FYI but running
make helmoverwrote a ton of stuff, almost all of which were out of scope of this PR. I've cherry-picked the bits of that this PR cares about.