Skip to content

Conversation

@JimMadge
Copy link
Member

@JimMadge JimMadge commented Apr 29, 2025

Closes #45

@JimMadge JimMadge changed the title Add example of curl to an external endpoint Add example workflows Apr 29, 2025
Comment on lines +15 to +18
- name: routput
path: /tmp/routput
s3:
key: /plot_gen.tgz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a sensible way to generalise this kind of thing?
It would be good to not put the responsibility on the users to makes/find writable directories.

Could we provide templates that ensure the job runs in a tmp dir and has loops like

outputs:
  artifacts:
{{% for output in outputs %}}
    - name: {{ output.name }}
      path: /tmp/{{job_id}}/{{ output.filename }}
      s3:
        key : {{ output.filename }}
{% endfor %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you wanting these to also be user-facing examples? Is this thinking ahead to what we've discussed about potentially locking down templates? I didn't realise these were really intended to exemplify that.

This was only intended to exemplify getting an artifact in and putting one out, not generalise to many output artifacts. This script just tars an entire directory and puts it in a single file in the default S3 bucket, so there is only one output and it doesn't need a loop.

@JimMadge JimMadge added this to fridge May 12, 2025
@github-project-automation github-project-automation bot moved this to To Be Refined in fridge May 12, 2025
@JimMadge JimMadge moved this from To Be Refined to In progress in fridge May 12, 2025
@JimMadge JimMadge removed this from fridge May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow examples

4 participants