-
Notifications
You must be signed in to change notification settings - Fork 13
add artifactpromotionrun notification solutions #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds two new documentation guides: one describing end-to-end ArtifactPromotionRun approval notifications via CorpWeChat (architecture, manifests, CEL filters, templates, verification, troubleshooting) and another detailing installation and offline setup for the Kube Event Enricher sink. Changes
Sequence Diagram(s)(omitted — documentation-only changes) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🪛 LanguageTooldocs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md[uncategorized] ~445-~445: The official name of this popular chat service is spelled with a capital “C”. (WECHAT) 🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.mddocs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
🧰 Additional context used
🪛 GitHub Actions: Build and Update
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
[error] 1-1: MDX compile error: Dead link found in /home/runner/work/knowledge/knowledge/docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
[error] 1-1: MDX compile error: Dead link found in /home/runner/work/knowledge/knowledge/docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
[error] 1-1: MDX compile error: Language cel is not included in this bundle. You may want to load it from external source.
[error] 1-1: MDX compile error: Language cel is not included in this bundle. You may want to load it from external source.
🪛 LanguageTool
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
[uncategorized] ~443-~443: The official name of this popular chat service is spelled with a capital “C”.
Context: ...orts multiple comma-separated values) | "wechat,corpwechat,email" | | `spec.subscriber...
(WECHAT)
🪛 markdownlint-cli2 (0.18.1)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
17-17: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
333-333: Table column count
Expected: 3; Actual: 4; Too many cells, extra data will be missing
(MD056, table-column-count)
🔇 Additional comments (1)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md (1)
440-449: Fix WeChat capitalization in example code.The official name uses proper capitalization: "WeChat" and "CorpWeChat".
🔎 Proposed fix
-| `metadata.annotations["core.katanomi.dev/sink.pluginclasses"]` | Notification channels (supports multiple comma-separated values) | `"wechat,corpwechat,email"` | +| `metadata.annotations["core.katanomi.dev/sink.pluginclasses"]` | Notification channels (supports multiple comma-separated values) | `"WeChat,CorpWeChat,Email"` |Likely an incorrect or invalid review comment.
...ons/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
Outdated
Show resolved
Hide resolved
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
Outdated
Show resolved
Hide resolved
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
Show resolved
Hide resolved
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
Show resolved
Hide resolved
354d73d to
3e07aa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (3)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md (3)
17-29: Add language identifier to ASCII diagram code block.The fenced code block is missing a language specifier. Add
textto enable proper rendering.🔎 Proposed fix
-``` +```text K8s Events (ArtifactPromotionRun) ↓ APIServerSource (Watches Event resources) @@ -26,7 +26,7 @@ ↓ CorpWeChat Notification Service (Katanomi Plugin) -``` +```text
335-335: Fix table column count mismatch caused by pipe character in inline command.The pipe character
|within the inline command (kubectl get users | grep) is incorrectly parsed as a table column separator, creating an extra cell. Rewrite the command description to avoid embedded pipes.🔎 Proposed fix
-| `spec.subscriber.info.id` | ACP user ID, you can retrive it by `kubectl get users | grep {subscriber.name}` | `21232f297a57a5a743894a0e4a801fc3` | +| `spec.subscriber.info.id` | ACP user ID, retrieve via: `kubectl get users` and filter by `{subscriber.name}` | `21232f297a57a5a743894a0e4a801fc3` |
454-460: Replace CEL code block language with text to fix MDX compilation.The
cellanguage identifier is not included in the MDX bundle and causes build failures. Change the code block language totextto allow documentation to build successfully.🔎 Proposed fix
#### CEL Filter Expression Examples -```cel +```text # Scenario 1: Subscriber is an approver ce.data.object.status.artifactPromotionSpec.approvalSpec.users.exists(item, item.name == "$(subscriber.name)")
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.mddocs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.md
🧰 Additional context used
🪛 GitHub Actions: Build and Update
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
[error] 1-1: MDX compile error: Language cel is not included in this bundle. You may want to load it from external source.
[error] 1-1: MDX compile error: Dead link found in /home/runner/work/knowledge/knowledge/docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
🪛 LanguageTool
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
[uncategorized] ~445-~445: The official name of this popular chat service is spelled with a capital “C”.
Context: ...orts multiple comma-separated values) | "wechat,corpwechat,email" | | `spec.subscriber...
(WECHAT)
🪛 markdownlint-cli2 (0.18.1)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
17-17: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
44-44: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
335-335: Table column count
Expected: 3; Actual: 4; Too many cells, extra data will be missing
(MD056, table-column-count)
🔇 Additional comments (2)
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md (2)
445-445: Capitalize WeChat product name correctly.The reference to "wechat" in the example should be capitalized as "WeChat" per the official product naming convention.
🔎 Proposed fix
-| `metadata.annotations["core.katanomi.dev/sink.pluginclasses"]` | Notification channels (supports multiple comma-separated values) | `"wechat,corpwechat,email"` | +| `metadata.annotations["core.katanomi.dev/sink.pluginclasses"]` | Notification channels (supports multiple comma-separated values) | `"WeChat,corpwechat,email"` |Likely an incorrect or invalid review comment.
74-74: No action required. The referenced installation guide fileArtifactPromotionRun_Approval_Notification_with_CorpWeChat_Install_kubeevent-enricher.mdexists in the same directory with the correct relative path, and the anchor section "Offline Package Preparation" is properly defined in the referenced file. Both links on lines 74 and 88 are valid.Likely an incorrect or invalid review comment.
docs/en/solutions/ArtifactPromotionRun_Approval_Notification_with_CorpWeChat.md
Outdated
Show resolved
Hide resolved
3e07aa0 to
38e96cf
Compare
Signed-off-by: chengjingtao <[email protected]>
38e96cf to
6a3851a
Compare
| Download the installation package from AlaudaCloud to your working directory: | ||
|
|
||
| ```bash | ||
| export DOWNLOAD_URL=https://xxx.xx/kubeveent-enricher.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上传正式包后替换为正式的地址
| @@ -0,0 +1,493 @@ | |||
| --- | |||
| id: KB2505xxxx | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有正式 KB ID后更新。
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.