-
Notifications
You must be signed in to change notification settings - Fork 14
style: mod tag input and tag color #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
WalkthroughThe changes update SCSS styles for tag components by adjusting background and border colors. Specific color shades are modified or removed for certain states and variants, including Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/tag/tag.component.scss (1)
138-141: Redundant background override inside.hasBorderblockInside
.hasBorderyou first setborder-color: use-rgb(n-8);then immediately overwrite the background with
use-rgb(button-bg), meaning the earlierbackground-color: use-rgb(n-8)(at line 136) is ignored whenever.hasBorderis present.Consider dropping the first background declaration to avoid dead CSS:
- background-color: use-rgb(n-8);Keeps the file leaner and avoids future confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/input/tags-input/mixin.scss(1 hunks)src/select/multi-select/multi-select.component.scss(0 hunks)src/tag/tag.component.scss(1 hunks)
💤 Files with no reviewable changes (1)
- src/select/multi-select/multi-select.component.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - aui
- GitHub Check: Header rules - aui
- GitHub Check: Unit Test
- GitHub Check: Release Beta
- GitHub Check: Pages changed - aui
🔇 Additional comments (2)
src/input/tags-input/mixin.scss (1)
18-21: Confirm new default bg color provides sufficient contrast in light & dark themes
use-rgb(n-7)is now the always-on background for every.aui-taginside the input.
Please double-check:
- Contrast ratio against the default text colour returned by
use-text-color(main)meets WCAG AA.- No unintended clash with
.aui-tag--info, which was darkened ton-8intag.component.scss.If either fails, consider a slightly lighter token (e.g.
n-6) or reverting to a theme-aware mixin.src/tag/tag.component.scss (1)
134-137: Shade shift ton-8might render text (n-2) too low-contrastMoving the info tag’s background from
n-7➜n-8darkens it; the foreground text colour is stilln-2.
Run a quick contrast audit to ensure the new pair still passes 4.5:1 for normal text sizes.If it fails, either revert to
n-7or bump the text to a lighter token (e.g.n-1).
Summary by CodeRabbit