Skip to content

Fix JET type stability warning in liouvillian function #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 365 commits into
base: main
Choose a base branch
from
Open

Fix JET type stability warning in liouvillian function #8

wants to merge 365 commits into from

Conversation

@albertomercurio
Copy link
Owner

Description

This PR fixes a JET static analysis warning in the liouvillian function by adding a type annotation to the Id_cache parameter.

Changes

  • Added ::Diagonal type annotation to Id_cache parameter in liouvillian function in src/qobj/superoperators.jl

Problem

JET was detecting a type instability issue where the Id_cache parameter had no type annotation, causing it to report:

no matching method found `_sum_lindblad_dissipators(::Tuple, ::Nothing)`, 
`_sum_lindblad_dissipators(::AbstractVector, ::Nothing)`, etc.

Solution

By adding the ::Diagonal type annotation, Julia can now properly infer that Id_cache will always be of type Diagonal, which matches what the _sum_lindblad_dissipators function expects.

Testing

All code quality tests now pass:

  • ✅ Aqua.jl: 9/9 tests passed
  • ✅ JET.jl: 1/1 test passed

albertomercurio and others added 30 commits November 10, 2024 03:32
@albertomercurio
Add doctest in all docstrings
87a9932
@ytdHuang
Add Makefile command for starting Vitepress locally and some minor ch…
f220410 
…anges (qutip#293)

* add Makefile command for starting Vitepress locally

* minor changes
@dependabot
Bump crate-ci/typos from 1.27.0 to 1.27.3
b3bde86 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.27.0 to 1.27.3.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.27.0...v1.27.3)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@ytdHuang
Bump crate-ci/typos from 1.27.0 to 1.27.3 (qutip#295)
0f5a9b1
@albertomercurio
Fix round error
c21855b
@ytdHuang
Add doctest in all docstrings (qutip#294)
ca872f6
@ytdHuang
updates for documentation (qutip#296)
cad8e14 
* fix repo link

* modify qutip hyper-link

* update bib

* update footer and fix toc

* fix latex `eqref`
@ytdHuang
Vitepress documentation (qutip#288)
a483e6f
@albertomercurio
Bump to v0.21.2
d11841d
@albertomercurio
Fix version picker in navbar
2559a7a
@ytdHuang
Fix VersionPicker.vue (qutip#297)
064df6b
@ytdHuang
add deploy_url
3cde23b
@ytdHuang
Fix documentation (qutip#298)
d2b1933 
* Fix documentation

* fix typo
@ytdHuang
Bump version to 0.21.3
eaddad0
@ytdHuang
fix the location of versions.js
afc70e4
@ytdHuang
Create CI pipeline to clean preview documentation
0229de3
@ytdHuang
minor changes
0889007
@ytdHuang
Fix the location of versions.js (qutip#299)
f15facb
@ytdHuang
Fix bad link for API button in home page (qutip#301)
2d24826 
* fix bad link for API button in home page

* fix spelling typo
@ytdHuang
update documentation (qutip#302)
2b05fa4
@ytdHuang
add contribute doc page (qutip#303)
42c4e07
@ytdHuang
fix contributing page (qutip#305)
e4cf394
@ytdHuang
Add CHANGELOG.md (qutip#306)
8d1717a 
* add CHANGELOG.md

* fix typos

* remove subsubsections in `CHANGELOG.md`

* update PR template

* rename `change_log` as `changelog`

* fix typo

* fix typo

* minor changes
@ytdHuang
fix incorrect bibliography (qutip#307)
4deb2f1
@albertomercurio
add allocations tests and clean time evolution tests (qutip#304)
3fd5a62 
* add allocations tests and clean time evolution tests

* Format Document

* Remove global tlist

* Fix format
@albertomercurio
Bump version to v0.21.4
43535b0
@ytdHuang
remove extra / in URL (qutip#308)
796d8f1
@ytdHuang
Bump version to v0.21.5 (qutip#309)
afded9a 
* bump version to `v0.21.5`

* bump version to `v0.21.5`
@ytdHuang
Try to fix several missing favicons in doc (qutip#310)
9567c45 
* try to fix several missing favicons in doc

* fix indent
@albertomercurio
Make time evolution solvers compatible with automatic differentiation (…
2836696 
…qutip#311)

* Working sesolve

* add `inplace` keywork argument

* add SciMLStructures and relax params type

* Working mcsolve (no type-stability)

* Fix type-instabilities for mcsolve

* Add SciMLStructures.jl methods

* Add callbacks helpers

* Fix dsf_mcsolve

* Remove ProgressBar from ODE parameters

* Fix abstol and reltol extraction

* Use Base allequal function

* Remove expvals from TimeEvolutionParameters

* Make NullParameters as default for params

* Remove custom PresetTimeCallback

* Update description of `inplace` argument

* Working mesolve

* Fix dfd_mesolve and dsf_mesolve

* Remove TimeEvolutionParameters (type-unstable)

* Fix type instabilities

* Fix type instabilities on Julia v1.10

* Format document
ytdHuang and others added 30 commits July 27, 2025 13:19
@ytdHuang
Bump compat of SciMLBase to fix piracy error (qutip#516)
8fb7406
@albertomercurio
Add documentation on Forward and Reverse differentiation (qutip#517)
536434b
@albertomercurio
Bump to v0.34.0 (qutip#518)
13709a1
@TendonFFF
Improve Bloch sphere rendering for animation (qutip#520)
5110d93
@dependabot
Bump crate-ci/typos from 1.34.0 to 1.35.3 (qutip#523)
4836664 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ytdHuang
[no ci] Add auto-diff to README (qutip#522)
f9f8213
@dependabot
Bump crate-ci/typos from 1.35.3 to 1.35.4 (qutip#527)
f0693e3 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@albertomercurio
Fix Zygote autodiff errors (qutip#530)
0b9a9f0
@dependabot
Bump actions/checkout from 4 to 5 (qutip#526)
fab15f7 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@albertomercurio
Add support for Enzyme autodiff (qutip#531)
d95bf63
@albertomercurio
Bump version to v0.34.1 (qutip#534)
6edcca1
@dependabot
Bump crate-ci/typos from 1.35.4 to 1.35.5 (qutip#535)
f7df5a7 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@TendonFFF
Add QobjEvo support for SteadyStateODESolver (qutip#536)
15954c9 
Co-authored-by: cailixun <[email protected]>
@ytdHuang
Fix keyword argument handling for SteadyStateODESolver (qutip#537)
75f33c4
@ytdHuang
Fix incorrect negativity and partial_transpose for arbitrary subs…
326c946 
…ystem dimension (qutip#539)
@albertomercurio
Bump to v0.35.0 (qutip#540)
be147e5
@dependabot
Bump crate-ci/typos from 1.35.5 to 1.36.2 (qutip#542)
c986d84 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@albertomercurio
Add sortby and rev arguments to eigensolver functions (qutip#546)
252e362
@ytdHuang
Fix Makie warning message (qutip#528)
3f6d8ed
@albertomercurio
Improve QuantumObjectEvolution generation function and fix `smesolv…
64a727c 
…e` type instabilities (qutip#548)
@ytdHuang @albertomercurio
Run code-quality CI also on Julia 1 (qutip#401)
b2c90b5 
Co-authored-by: Alberto Mercurio <[email protected]>
@dependabot
Bump crate-ci/typos from 1.36.2 to 1.36.3 (qutip#549)
e491540 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ytdHuang
Update citation bibtex for publication and add cite() (qutip#544)
b5209bd
@albertomercurio
Bump version to v0.36.0 (qutip#550)
fbbf981
@ytdHuang
Fix typo in cite (qutip#551)
8d6922a
@dependabot @ytdHuang
Bump crate-ci/typos from 1.36.3 to 1.37.2 (qutip#553)
4e05b92 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yi-Te Huang <[email protected]>
@ytdHuang
Fix cite() bibtex output (qutip#552)
894213b
@albertomercurio
Add benchmarks for time-dependent evolutions (qutip#556)
849ffcb
@TendonFFF
add qeye_like and qzero_like (qutip#555)
7a2a5fc 
Co-authored-by: cailixun <[email protected]>
@albertomercurio
Add code quality support for Julia v1.12
da5ecb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albertomercurio @ytdHuang @TendonFFF @matteosecli @Fe-r-oz