Open
Conversation
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
AI Pull Request OverviewSummary
Approval rating (1-10)5/10 - Technically sound implementation but lacks critical evaluation of tool selection criteria, security implications, and long-term maintenance. Summary per fileSummary per file
Overall AssessmentThe PR successfully expands arkade's tool ecosystem by adding popular CLI utilities, demonstrating good technical implementation with proper testing and platform support. However, the approach of adding tools based on ChatGPT suggestions without documented evaluation criteria raises significant concerns about tool quality, security, licensing, and maintenance burden. Security tools like trufflehog and gitleaks require particular scrutiny for trustworthiness and official distribution channels. Detailed ReviewDetailed ReviewREADME.md
pkg/get/get_test.go
pkg/get/tools.go
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add various tools suggested by ChatGPT
Motivation and Context
Adds various popular tools suggested via ChatGPT that have static binaries on GitHub
How Has This Been Tested?
amp ran the usual tests with
--os/--archetc.Types of changes
Documentation
./arkade get --format markdown./arkade install --help