MAGE-1404: Refactored config.xml #1818
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
changed the title
cammonro
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Looks great! I think this is a much more sensible approach to the integration test fixture.
I am wondering if we should preserve the patch for the settings migrations only? Though we'd have to review the changelog to see when those settings were relocated. Otherwise if someone is upgrading from that older version I would imagine that their settings will not carry over.
| */ | ||
| public function apply() | ||
| { | ||
| $movedConfigDirectives = [ |
There was a problem hiding this comment.
I'm not sure during which version of the extension these moved settings were introduced - but I'm wondering if we should add a migrate patch for these as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
config.xmlfiles with values contained inConfigPatch.phpDefaultConfigProvider.phpto be used by integration testsTestCase.phpto use this new providerConfigPatch.php