Skip to content

Expose text field background / foreground colors to enable dark mode support #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose text field background / foreground colors to enable dark mode support #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4205442
Expose text field background color to enable dark mode support
msmollin Jul 15, 2022
2dc9a64
update to include foreground color
JoeCotellese Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions Sources/InstantSearchSwiftUI/View/SearchBar.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ public struct SearchBar: View {

/// Whether the search bar is in the editing state
@Binding public var isEditing: Bool

/// Customizable background color for the main text field
@State public var searchBarBackgroundColor =
Color(.sRGB, red: 239/255, green: 239/255, blue: 240/255, opacity: 1)

@State public var searchBarForegroundColor = Color(.gray)

private let placeholder: String
private var onSubmit: () -> Void

Expand All @@ -47,7 +53,7 @@ public struct SearchBar: View {
.overlay(
HStack {
Image(systemName: "magnifyingglass")
.foregroundColor(.gray)
.foregroundColor(searchBarForegroundColor)
.frame(minWidth: 0, maxWidth: .infinity, alignment: .leading)
.padding(.leading, 8)
.disabled(true)
Expand All @@ -57,7 +63,7 @@ public struct SearchBar: View {
},
label: {
Image(systemName: "multiply.circle.fill")
.foregroundColor(.gray)
.foregroundColor(searchBarForegroundColor)
.padding(.trailing, 8)
})
}
Expand All @@ -66,15 +72,15 @@ public struct SearchBar: View {
.onTapGesture {
isEditing = true
}
.background(Color(.sRGB, red: 239/255, green: 239/255, blue: 240/255, opacity: 1))
.background(searchBarBackgroundColor)
.cornerRadius(10)
if isEditing {
Button(action: {
isEditing = false
},
label: {
Text("Cancel")
})
Button<Text> {
isEditing = false
} label: {
Text("Cancel")
}
.padding(.trailing, 10)
.transition(.move(edge: .trailing))
.animation(.default)
Expand Down