fix(rendering): ensure resilience against "null" results #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases `results` in `render` can be null: - no index name passed - stalled render In the vast majority of cases we already handled `results` being `null` or `undefined` just in case, but now i've changed the type to ensure we always catch this problem This issue doesn't have a reproduction, but i believe it now guards for all possible cases of "no results", so: fixes #6441 [CR-7353]
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Haroenv
requested review from
a team,
dhayab and
shaejaz
and removed request for
a team
shaejaz
approved these changes
Nov 19, 2024
Contributor
shaejaz
left a comment
shaejaz
left a comment
There was a problem hiding this comment.
lgtm!
Since this might result in type errors, would this count as a breaking change?
Contributor
Author
|
don't think so as the type already was able to be null, it was just typed wrong @shaejaz |
Haroenv
added
the
🚨 DO NOT MERGE
dhayab
approved these changes
Nov 20, 2024
Contributor
Author
|
This will be merged and released after code freeze is over; if you bump into the "results is null" error, you can ignore it as the page still behaves correctly, when results is null no events can have happened yet |
dhayab
removed
the
🚨 DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases
resultsinrendercan be null:instantsearch/packages/algoliasearch-helper/src/algoliasearch.helper.js
Lines 1503 to 1510 in a896774
In the vast majority of cases we already handled
resultsbeingnullorundefinedjust in case, but now i've changed the type to ensure we always catch this problemResult
null is handled in all cases for results
This issue doesn't have a reproduction, but i believe it now guards for all possible cases of "no results", so:
fixes #6441
CR-7353