Skip to content

Conversation

thomasbritton
Copy link
Contributor

@thomasbritton thomasbritton commented Feb 28, 2025

Current Refinements and Clear Refinements buttons

Screenshot 2025-03-25 at 10 09 22

Screenshot 2025-03-25 at 10 09 37

@thomasbritton thomasbritton self-assigned this Feb 28, 2025
@thomasbritton thomasbritton changed the base branch from master to feat/algoliacss February 28, 2025 15:01
Copy link

codesandbox-ci bot commented Feb 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a98651:

Sandbox Source
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@sarahdayan
Copy link
Member

Clear refinements

I think the button should look the same as the show more buttons in the refinement list and hierarchical menu, what do you think?

Current refinements

The border and icon colors look too dark to me, I think we should use the alpha values that go with the picked colors to have something more consistent, + add a hover color on the delete button to convey that there's an action.

Capture d’écran 2025-03-03 à 11 11 50

If you don't have time to go over it @thomasbritton but you agree, I can take care of it.

@thomasbritton
Copy link
Contributor Author

Clear refinements

I think the button should look the same as the show more buttons in the refinement list and hierarchical menu, what do you think?

Current refinements

The border and icon colors look too dark to me, I think we should use the alpha values that go with the picked colors to have something more consistent, + add a hover color on the delete button to convey that there's an action.

Capture d’écran 2025-03-03 à 11 11 50 If you don't have time to go over it @thomasbritton but you agree, I can take care of it.

Hey @sarahdayan , sure I think those suggestions sound good, but I'm probably not going to have much time to look into it, so if you don't mind taking over it that would be great.

@thomasbritton
Copy link
Contributor Author

@sarahdayan @FabienMotte I have made amends based on the feedback

@thomasbritton thomasbritton merged commit 1371c23 into feat/algoliacss Mar 25, 2025
10 checks passed
@thomasbritton thomasbritton deleted the feat/algoliacss-current-refinements branch March 25, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants