feat(autocomplete): implement basic shared DOM #6709
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** @jsx createElement */ | ||
|
|
||
| import { cx } from '../../lib/cx'; | ||
|
|
||
| import type { ComponentChildren, Renderer } from '../../types'; | ||
|
|
||
| export type AutocompleteProps = { | ||
| isOpen: boolean; | ||
| children?: ComponentChildren; | ||
| classNames?: Partial<AutocompleteClassNames>; | ||
| }; | ||
|
|
||
| export type AutocompleteClassNames = { | ||
| /** | ||
| * Class names to apply to the root element | ||
| */ | ||
| root: string | string[]; | ||
| }; | ||
|
|
||
| export function createAutocompleteComponent({ createElement }: Renderer) { | ||
| return function Autocomplete(userProps: AutocompleteProps) { | ||
| const { children, isOpen, classNames = {} } = userProps; | ||
|
|
||
| return ( | ||
| <div | ||
| className={cx('ais-Autocomplete', classNames.root)} | ||
| role="combobox" | ||
| aria-expanded={isOpen} | ||
| aria-haspopup="listbox" | ||
| > | ||
| {children} | ||
| </div> | ||
| ); | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /** @jsx createElement */ | ||
|
|
||
| import { cx } from '../../lib/cx'; | ||
|
|
||
| import type { Renderer } from '../../types'; | ||
|
|
||
| export type AutocompleteIndexProps< | ||
| T = { objectID: string } & Record<string, unknown> | ||
| > = { | ||
| items: T[]; | ||
| ItemComponent: (item: T) => JSX.Element; | ||
| classNames?: Partial<AutocompleteIndexClassNames>; | ||
| }; | ||
|
|
||
| export type AutocompleteIndexClassNames = { | ||
| /** | ||
| * Class names to apply to the root element | ||
| **/ | ||
| root: string | string[]; | ||
| /** | ||
| * Class names to apply to the list element | ||
| */ | ||
| list: string | string[]; | ||
| /** | ||
| * Class names to apply to each item element | ||
| */ | ||
| item: string | string[]; | ||
| }; | ||
|
|
||
| export function createAutocompleteIndexComponent({ createElement }: Renderer) { | ||
| return function AutocompleteIndex(userProps: AutocompleteIndexProps) { | ||
| const { items, ItemComponent, classNames = {} } = userProps; | ||
|
|
||
| return ( | ||
| <div className={cx('ais-AutocompleteIndex', classNames.root)}> | ||
| <ul className={cx('ais-AutocompleteIndexList', classNames.list)}> | ||
aymeric-giraudet marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Haroenv marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| {items.map((item) => ( | ||
| <li | ||
| key={item.objectID} | ||
| className={cx('ais-AutocompleteIndexItem', classNames.item)} | ||
| > | ||
| <ItemComponent {...item} /> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| </div> | ||
| ); | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /** @jsx createElement */ | ||
|
|
||
| import { cx } from '../../lib/cx'; | ||
|
|
||
| import type { ComponentChildren, Renderer } from '../../types'; | ||
|
|
||
| export type AutocompletePanelProps = { | ||
| isOpen: boolean; | ||
| children?: ComponentChildren; | ||
| classNames?: Partial<AutocompletePanelClassNames>; | ||
| }; | ||
|
|
||
| export type AutocompletePanelClassNames = { | ||
| /** | ||
| * Class names to apply to the root element | ||
| */ | ||
| root: string | string[]; | ||
| /** | ||
| * Class names to apply to the layout element | ||
| */ | ||
| layout: string | string[]; | ||
| }; | ||
|
|
||
| export function createAutocompletePanelComponent({ createElement }: Renderer) { | ||
| return function AutocompletePanel(userProps: AutocompletePanelProps) { | ||
| const { children, isOpen, classNames = {} } = userProps; | ||
|
|
||
| return ( | ||
| <div | ||
| className={cx('ais-AutocompletePanel', classNames.root)} | ||
| hidden={!isOpen} | ||
| > | ||
| <div className={cx('ais-AutocompletePanelLayout', classNames.layout)}> | ||
| {children} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export * from './Autocomplete'; | ||
| export * from './AutocompleteIndex'; | ||
| export * from './AutocompletePanel'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from './Carousel'; | ||
| export * from './Autocomplete'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a later iteration (when we do the final dom) we likely want to have the search box be part of this too, and then all the intermediate components also be part of the autocomplete. For now this is a logical split.