-
Notifications
You must be signed in to change notification settings - Fork 519
Afrz: ASA Global Freeze #6298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nullun
wants to merge
30
commits into
algorand:master
Choose a base branch
from
nullun:feature/asa-global-freeze
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Afrz: ASA Global Freeze #6298
Changes from 22 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
e5725b8
initial proof of concept
nullun d837ec2
afrz transactions are used to configure global freeze
nullun d6a6e25
minor text/key name changes
nullun 436d2c2
Update goal and API responses
nullun 849f2d4
Remove gfrz field from afrz transaction
nullun c4ea51a
Remove unused flag in 'goal asset freeze'
nullun 1d1044d
Change GlobalFreeze codec from '0' to 'G'
nullun e0954a4
update "asset_holding_get" and "asset_params_get" opcodes
ori-shem-tov 7232431
Merge pull request #2 from ori-shem-tov/feature/asa-global-freeze
nullun 7d41877
Update and regen langspec and readme
nullun 3e7d594
Fix 'asset_holding_get AssetFrozen' backwards compatibility, if asset…
nullun a4716ea
Allow asset holding to be unfrozen whilst asset params are globally f…
nullun f8db258
Updates following review
nullun 4f19688
use existing vfuture consensus
nullun 3af7cc0
use existing pattern for returning default values
nullun e11abe8
Rename function and provide context
nullun b82ceae
API: Expose frozen boolean and remove last freeze uint64
nullun d1bf5b1
merge latest master into feature branch
nullun 7e6911a
Add wellFormed() for all asset transaction types
nullun 20c3770
TEAL: Hide uint64 fields, expose boolean
nullun f121e8b
Update ledger field keys
nullun 292a68f
Reverted opdoc to v11, removing all TEAL v12 output
nullun 592554d
Added various tests
nullun d8f4bf5
Merge branch 'master' into feature/asa-global-freeze
nullun 78593ec
regenerate algod api
nullun 6cdd2b1
Additional test for unfreezing an individual
nullun b5c5d5d
Fix the gated empty FreezeAccount wellFormed check
nullun 980bed3
added two new fields LastGlobalFreeze and LastFreezeChange
nullun 09be117
Set new field values 1 in 5 times
nullun f0d8ea7
Merge branch 'master' into feature/asa-global-freeze
nullun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for feedback here. From what I can gather
AccountToAccountData()is only used by dryrun/tealdbg and then used in 2 tests, but I'm not sure how much energy is going into maintaining them?Essentially there's now a difference between what
basics.AccountDataandmodel.Accountholds.basics.AssetHolding.LastFreezeChangeaway inmodel.AssetHoldingafter changing theIsFrozenvalue.basics.AssetParams.LastGlobalFreezeaway inmodel.AssetParamsafter adding theFrozenboolean value.Generally this conversion is done in one direction (from
basics.AccountDatatomodel.Account), so it didn't seem like a problem. But if using dryrun I'm now lying about theLastGlobalFreezevalue, so it would always win regardless of an accounts local Freeze/LastFreezeChange.