Skip to content

fix: Increase client_max_body_size to support large file uploads#472

Open
kinboyw wants to merge 1 commit intoalibaba:masterfrom
kinboyw:master
Open

fix: Increase client_max_body_size to support large file uploads#472
kinboyw wants to merge 1 commit intoalibaba:masterfrom
kinboyw:master

Conversation

@kinboyw
Copy link
Copy Markdown

@kinboyw kinboyw commented Apr 28, 2025

This PR modifies the NGINX configuration template (pkg/router/route.conf) to support larger file uploads by adding:

client_max_body_size 1000m;

Changes:
• Added client_max_body_size 1000m; directive to the NGINX router configuration

• This allows file uploads up to 1000MB (1GB) through kt-connect

Context:
The default NGINX client_max_body_size (typically 1m) was insufficient for file transfer use cases. This change enables:
• Reliable transfer of medium/large files

• Better compatibility with file upload requirements

• Maintains existing security constraints while increasing practical limits

Testing:
• [x] Verified file uploads up to 1000MB work correctly

• [x] Confirmed existing functionality remains unaffected

• [x] Tested with both HTTP and HTTPS connections

Impact:
• Improves file transfer capabilities without requiring client-side changes

• Backward compatible with all existing deployments

Additional Notes:
The 1000m limit can be adjusted in future if needed by modifying this configuration value.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 5175abb and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants