fix: Increase client_max_body_size to support large file uploads#472
Open
kinboyw wants to merge 1 commit intoalibaba:masterfrom
Open
fix: Increase client_max_body_size to support large file uploads#472kinboyw wants to merge 1 commit intoalibaba:masterfrom
kinboyw wants to merge 1 commit intoalibaba:masterfrom
Conversation
|
|
|
Code Climate has analyzed commit 5175abb and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the NGINX configuration template (
pkg/router/route.conf) to support larger file uploads by adding:Changes:
• Added
client_max_body_size 1000m;directive to the NGINX router configuration• This allows file uploads up to 1000MB (1GB) through kt-connect
Context:
The default NGINX client_max_body_size (typically 1m) was insufficient for file transfer use cases. This change enables:
• Reliable transfer of medium/large files
• Better compatibility with file upload requirements
• Maintains existing security constraints while increasing practical limits
Testing:
• [x] Verified file uploads up to 1000MB work correctly
• [x] Confirmed existing functionality remains unaffected
• [x] Tested with both HTTP and HTTPS connections
Impact:
• Improves file transfer capabilities without requiring client-side changes
• Backward compatible with all existing deployments
Additional Notes:
The 1000m limit can be adjusted in future if needed by modifying this configuration value.