feat: support aarch64 architecture for JindoSDK dependency#163
Open
SteNicholas wants to merge 1 commit intoalibaba:mainfrom
Open
feat: support aarch64 architecture for JindoSDK dependency#163SteNicholas wants to merge 1 commit intoalibaba:mainfrom
SteNicholas wants to merge 1 commit intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds architecture-aware selection of prebuilt JindoSDK C packages so builds can work on aarch64 (Linux and macOS).
Changes:
- Split JindoSDK package names and SHA256 checksums by OS/architecture in
versions.txt. - Update CMake toolchain logic to pick the correct JindoSDK URL/checksum and dynamic library filename for Linux/Darwin and x86_64/aarch64.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| third_party/versions.txt | Introduces per-OS/arch JindoSDK package variables (name, checksum, URL entries). |
| cmake_modules/ThirdpartyToolchain.cmake | Selects JindoSDK artifact/checksum and library name based on platform/CPU architecture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lxy-9602
reviewed
Mar 3, 2026
| else() | ||
| set_urls(JINDOSDK_C_SOURCE_URL | ||
| "https://jindodata-binary.oss-cn-shanghai.aliyuncs.com/release/${PAIMON_JINDOSDK_C_BUILD_VERSION}/jindosdk-${PAIMON_JINDOSDK_C_BUILD_VERSION}-macos-11_0-aarch64.tar.gz" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Just to confirm: after adjusting Jindo, does the build now work on macOS?
If so, we could update the README to reflect that x86 and macOS are supported (with known limitations).
Specifically: Lumina and Lance are still not supported on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #162
Support aarch64 architecture for JindoSDK dependency. The sha256sum of JindoSDK packages are as follows:
Tests
Local test on MacOS(M4).
API and Format
No.
Documentation
No.