-
Notifications
You must be signed in to change notification settings - Fork 18
[Playground] Add Events components #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/181-components
…to feature/181-components
…to feature/181-components
테스트 부분도 구현했습니다. 추가 변경점테스트
기능
|
justinyoo
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드에 생각이 너무 많은 것 같아요. 단순하게 볼 수 있는 방법이 있을 겁니다.
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Events.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
justinyoo
requested changes
Sep 11, 2024
src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Events.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
justinyoo
requested changes
Sep 20, 2024
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
justinyoo
requested changes
Sep 23, 2024
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
…to feature/181-components
헤더, summary 존재여부와 클릭 가능 여부를 테스트하는 코드도 추가했습니다. |
…to feature/181-components
justinyoo
requested changes
Oct 3, 2024
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventListComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/EventItemComponent.razor
Show resolved
Hide resolved
…to feature/181-components
…to feature/181-components
justinyoo
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #181
Changes
/events/
경로 아래에 Events 페이지 추가Description
EventItemComponent의 색은 임의로 넣었습니다.
Tasks
궁금한 점
테스트 코드는 아직 미완성입니다.