Connector Implementation & Inheritance: LG AI EXAONE #465

jh941213 · 2025-09-25T08:18:44Z

Purpose

closes Connector Implementation & Inheritance: LG AI EXAONE Connector Implementation & Inheritance: LG AI EXAONE #253
Implement LGConnector class that inherits from LanguageModelConnector
Add AppSettings dependency injection for LG AI EXAONE configuration
Override GetChatClient method to provide LG AI EXAONE chat client functionality
Enable LG AI EXAONE integration through Ollama-compatible API

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] New feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

README updated?

The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?

[ ] Yes
[ ] No
[x] N/A

How to Test

Get the code

git clone https://github.com/tae0y/open-chat-playground.git
cd open-chat-playground
git checkout feature/253

Test the code

dotnet test test/OpenChat.PlaygroundApp.Tests/OpenChat.PlaygroundApp.Tests.csproj --filter "FullyQualifiedName~LGConnectorTests"
dotnet run --project ./src/OpenChat.PlaygroundApp/ -- --connector-type LG --base-url http://localhost:11434 --model lg-exaone-model

What to Check

Verify that the following are valid

LGConnector class properly inherits from LanguageModelConnector
AppSettings dependency injection works correctly for LG configuration
GetChatClientAsync method returns valid IChatClient instance
LG connector type is properly registered in LanguageModelConnector.CreateChatClientAsync
All LGConnectorTests pass successfully
LG connector integrates seamlessly with existing connector infrastructure

Other Information

This implementation follows the same pattern as Ollama connector implementation, using OllamaSharp library for LG AI EXAONE integration. The connector:

Uses Ollama-compatible API for LG AI EXAONE models
Requires only BaseUrl and Model configuration (no API key needed for open source models)
Implements proper validation for required configuration settings
Provides comprehensive error handling for missing or invalid configurations

Key components added:

LGConnector.cs - Main connector implementation
LGConnectorTests.cs - Comprehensive unit tests
Updated LanguageModelConnector.cs to include LG case in factory method

The implementation enables users to run LG AI EXAONE models through the OpenChat Playground interface using the same infrastructure as other supported connectors.

src/OpenChat.PlaygroundApp/Connectors/LGConnector.cs

test/OpenChat.PlaygroundApp.Tests/Connectors/LGConnectorTests.cs

justinyoo · 2025-09-28T05:47:48Z

@jh941213 머지 컨플릭도 해소해 주세요. 이번에는 리베이스 하다 망하지 마시고 차근차근...

jh941213 · 2025-09-28T09:15:12Z

453 브랜치 생성을 못하고 시작 해서, 그부분은 컨플릭트 수정하고, 이 이슈까진 253 사용하고 인지하고 있겠습니다

justinyoo · 2025-09-29T01:26:36Z

src/OpenChat.PlaygroundApp/Abstractions/LanguageModelConnector.cs

        LanguageModelConnector connector = settings.ConnectorType switch
        {
            ConnectorType.GitHubModels => new GitHubModelsConnector(settings),
+            ConnectorType.LG => new LGConnector(settings),


#155 보시고 순서 맞춰 넣어주세요.

justinyoo · 2025-09-29T01:27:00Z

src/OpenChat.PlaygroundApp/Abstractions/LanguageModelConnector.cs

            ConnectorType.GitHubModels => new GitHubModelsConnector(settings),
+            ConnectorType.LG => new LGConnector(settings),
            ConnectorType.HuggingFace => new HuggingFaceConnector(settings),
+


여기에는 빈 줄이 필요 없습니다.

justinyoo · 2025-09-29T01:29:56Z

src/OpenChat.PlaygroundApp/Connectors/LGConnector.cs

+        // Validate LG model format: should be HuggingFace format, LG model, or GGUF format
+        var model = settings.Model.Trim();
+        var isHuggingFaceFormat = model.StartsWith("hf.co/") || model.Contains("/");
+        var isLGModel = model.ToLowerInvariant().Contains("exaone") || model.ToLowerInvariant().Contains("lg");
+        var isGGUFFormat = model.ToLowerInvariant().EndsWith(".gguf") || model.ToLowerInvariant().Contains("gguf");
+
+        if (!isHuggingFaceFormat && !isLGModel && !isGGUFFormat)
+        {
+            throw new InvalidOperationException("Invalid LG model format. Model should be HuggingFace format (hf.co/...), LG model (containing 'exaone' or 'lg'), or GGUF format (containing 'gguf').");
+        }


이 메소드 하나에서 이 모든 것을 다 validation 하는 것이 좋을까요, 아니면 이 로직은 별도의 private bool 메소드로 빼는 것이 좋을까요? 허깅페이스 커넥터 로직 한 번 보실랍니까?

open-chat-playground/src/OpenChat.PlaygroundApp/Connectors/HuggingFaceConnector.cs

Lines 65 to 85 in b6ec80b

private static bool IsValidModel(string model)

{

var segments = model.Split(new[] { '/' }, StringSplitOptions.RemoveEmptyEntries);

if (segments.Length != 3)

{

return false;

}

if (segments.First().Equals(HuggingFaceHost, StringComparison.InvariantCultureIgnoreCase) == false)

{

return false;

}

if (segments.Last().EndsWith(ModelSuffix, StringComparison.InvariantCultureIgnoreCase) == false)

{

return false;

}

return true;

}

비효율적인거 같습니다 참고하겠습니다

justinyoo · 2025-09-29T01:31:44Z

test/OpenChat.PlaygroundApp.Tests/Connectors/LGConnectorTests.cs

+    [InlineData("hf.co/LGAI-EXAONE/EXAONE-4.0-1.2B-GGUF")]
+    [InlineData("LGAI-EXAONE/EXAONE-4.0-1.2B")]
+    [InlineData("lg-exaone-model")]
+    [InlineData("exaone-3.0")]
+    [InlineData("model.gguf")]
+    [InlineData("exaone-gguf-model")]


여기 있는 모델들이 다 LG 모델 맞나요?

[Fact] 를 활용해서 단일 엘지 커넥트로 수정하겠습니다

justinyoo · 2025-09-29T01:34:10Z

test/OpenChat.PlaygroundApp.Tests/Connectors/LGConnectorTests.cs

+    [Trait("Category", "UnitTest")]
+    [Theory]
+    [InlineData(null, typeof(NullReferenceException), "Object reference not set to an instance of an object")]
+    [InlineData("", typeof(InvalidOperationException), "LG:Model")]
+    [InlineData("   ", typeof(InvalidOperationException), "LG:Model")]
+    public void Given_Invalid_Model_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Throw(string? model, Type expectedType, string expectedMessage)
+    {
+        // Arrange
+        var appSettings = BuildAppSettings(model: model);
+        var connector = new LGConnector(appSettings);
+
+        // Act
+        Action action = () => connector.EnsureLanguageModelSettingsValid();
+
+        // Assert
+        action.ShouldThrow(expectedType)
+              .Message.ShouldContain(expectedMessage);
+    }
+
+    [Trait("Category", "UnitTest")]
+    [Theory]
+    [InlineData("invalid-model", typeof(InvalidOperationException), "Invalid LG model format")]
+    [InlineData("random-name", typeof(InvalidOperationException), "Invalid LG model format")]
+    [InlineData("test-model", typeof(InvalidOperationException), "Invalid LG model format")]
+    public void Given_Invalid_Model_Format_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Throw(string model, Type expectedType, string expectedMessage)
+    {
+        // Arrange
+        var appSettings = BuildAppSettings(model: model);
+        var connector = new LGConnector(appSettings);
+
+        // Act
+        Action action = () => connector.EnsureLanguageModelSettingsValid();
+
+        // Assert
+        action.ShouldThrow(expectedType)
+              .Message.ShouldContain(expectedMessage);
+    }


이 테스트 두 개를 따로 놓는 대신 합치면 안되나요?

justinyoo · 2025-09-29T01:35:04Z

test/OpenChat.PlaygroundApp.Tests/Connectors/LGConnectorTests.cs

+    [Trait("Category", "UnitTest")]
+    [Theory]
+    [InlineData(null, typeof(ArgumentNullException))]
+    [InlineData("", typeof(UriFormatException))]
+    public void Given_Missing_BaseUrl_When_GetChatClient_Invoked_Then_It_Should_Throw(string? baseUrl, Type expected)
+    {
+        // Arrange
+        var settings = BuildAppSettings(baseUrl: baseUrl);
+        var connector = new LGConnector(settings);
+
+        // Act
+        Func<Task> func = async () => await connector.GetChatClientAsync();
+
+        // Assert
+        func.ShouldThrow(expected);
+    }


Base URL 값만 테스트했는데, 모델 값도 테스트를 추가해야 합니다.

justinyoo · 2025-09-29T01:36:31Z

test/OpenChat.PlaygroundApp.Tests/Connectors/LGConnectorTests.cs

+    [Trait("Category", "UnitTest")]
+    [Fact]
+    public void Given_Invalid_Settings_When_CreateChatClientAsync_Invoked_Then_It_Should_Throw()
+    {
+        // Arrange
+        var settings = new AppSettings
+        {
+            ConnectorType = ConnectorType.LG,
+            LG = new LGSettings
+            {
+                BaseUrl = null,
+                Model = "lg-exaone-model"
+            }
+        };
+
+        // Act
+        Func<Task> func = async () => await LanguageModelConnector.CreateChatClientAsync(settings);
+
+        // Assert
+        func.ShouldThrow<NullReferenceException>();
+    }


invalid 세팅을 테스트하는데, base URL 값과 모델 값을 테스트하려면 [Fact] 대신 [Theory]를 써서 [InlineData(...)]를 추가해 보세요.

jh941213 added 2 commits September 25, 2025 17:16

feat: add new feature

30cb95b

fixed test error

23823da

tae0y requested a review from justinyoo September 25, 2025 12:05

tae0y assigned jh941213 Sep 25, 2025

tae0y added ossca p1 phase-1 team-jeon vendor task labels Sep 25, 2025

tae0y linked an issue Sep 25, 2025 that may be closed by this pull request

Connector Implementation & Inheritance: LG AI EXAONE #253

Open

justinyoo requested changes Sep 25, 2025

View reviewed changes

jh941213 added 3 commits September 28, 2025 17:50

Merge main into feature/253 - resolve conflicts

ee32fe7

fixed comment

bc87f7b

build test fixed, exception updated

1138850

justinyoo requested changes Sep 29, 2025

View reviewed changes

jh941213 added 3 commits September 30, 2025 09:14

Merge branch 'main' into feature/253

c40bc40

comment fixed

943181c

build fail rebuilding

a083e7c

	private static bool IsValidModel(string model)
	{
	var segments = model.Split(new[] { '/' }, StringSplitOptions.RemoveEmptyEntries);

	if (segments.Length != 3)
	{
	return false;
	}

	if (segments.First().Equals(HuggingFaceHost, StringComparison.InvariantCultureIgnoreCase) == false)
	{
	return false;
	}

	if (segments.Last().EndsWith(ModelSuffix, StringComparison.InvariantCultureIgnoreCase) == false)
	{
	return false;
	}

	return true;
	}

Connector Implementation & Inheritance: LG AI EXAONE #465

Are you sure you want to change the base?

Connector Implementation & Inheritance: LG AI EXAONE #465

Conversation

jh941213 commented Sep 25, 2025

Purpose

Does this introduce a breaking change?

Pull Request Type

README updated?

How to Test

What to Check

Other Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinyoo commented Sep 28, 2025

Uh oh!

jh941213 commented Sep 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!