Skip to content

feat: Environment Variables Testing: Foundry Local #213 #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Environment Variables Testing: Foundry Local #213 #468

wants to merge 3 commits into from

Conversation

ummjevel
Copy link
Contributor

@ummjevel ummjevel commented Sep 29, 2025 •
edited
Loading

Resolves #213

Purpose

  • Environment variables integration is a built-in feature. This task is to ensure the integration is working. Add unit tests.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] New feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

README updated?

The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?

[ ] Yes
[x] No
[ ] N/A

How to Test

  • Get the code
git clone https://github.com/aliencube/open-chat-playground.git
cd open-chat-playground
git checkout feature/213-envvartest-foundrylocal
  • Test the code
dotnet build
dotnet test --filter Category=UnitTest

What to Check

Verify that the following are valid

  1. Run tests - Execute all FoundryLocal tests to ensure they pass
  2. Code style check - Verify formatting matches existing codebase standards
  3. Test coverage - Confirm all environment variable scenarios are covered

Other Information

@ummjevel ummjevel changed the title feature : Environment Variables Testing: Foundry Local #213 feat: Environment Variables Testing: Foundry Local #213 Sep 29, 2025
@tae0y tae0y requested a review from justinyoo September 29, 2025 12:00
justinyoo
justinyoo requested changes Oct 2, 2025
View reviewed changes
test/OpenChat.PlaygroundApp.Tests/Options/FoundryLocalArgumentOptionsTests.cs Outdated
Comment on lines 182 to 183
public void Given_EnvironmentVariables_And_No_Config_When_Parse_Invoked_Then_It_Should_Use_EnvironmentVariables(
string envAlias)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳이 두 줄로 구분한 이유가 있나요?

test/OpenChat.PlaygroundApp.Tests/Options/FoundryLocalArgumentOptionsTests.cs Outdated
Comment on lines 202 to 203
public void Given_ConfigValues_And_EnvironmentVariables_When_Parse_Invoked_Then_It_Should_Use_EnvironmentVariables(
string configAlias, string envAlias)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도

test/OpenChat.PlaygroundApp.Tests/Options/FoundryLocalArgumentOptionsTests.cs Outdated
Comment on lines 288 to 289
public void Given_EnvironmentVariables_Only_When_Parse_Invoked_Then_Help_Should_Be_False(
string envAlias)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도

@ummjevel
Copy link
Contributor Author

ummjevel commented Oct 3, 2025

@justinyoo 줄바꿈한 이유는 없어서 줄바꿈 삭제 반영하였습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo requested changes

Assignees

@ummjevel ummjevel

Labels
local ossca p1 phase-1 task team-jeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment Variables Testing: Foundry Local
3 participants
@ummjevel @justinyoo @tae0y