-
Notifications
You must be signed in to change notification settings - Fork 147
fix: update dependencies to address security issue in @babel/runtime < 7.26.10 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
What is remaining for this ? |
|
This project looks pretty dead, unfortunately. The last commit was 2 years ago. 😒 |
It's very hard to maintain a project that big when most of the core maintainers move on or can't find time to maintain it (and then it's down to a single person for a long time). I'm in a slightly better place now (although I still have loads on my plate that will make finding time and energy for OSS stuff a challenge), but hopefully the people who came forward and expressed interest in helping will get this project back on track. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good, hovewer the commit doesn't follow the Angular commit convention so the commit message and PR title would need to be updated.
|
@marcelpanse Do you mind updating the PR title and commit message to something like: "fix: update dependencies to address security issue in @babel/runtime < 7.26.10" |
|
Looks like we need to update the min node version from 16 to 18, is that doable? |
|
I dont have the permissions, but the solution here is to update the engine.node version to 22 (current lts) and the nvmrc file also to 22.14.0 |
|
I went and made a duplicate PR #375, i tried to address all the primary issues i was seeing when running the library |
Package: @babel/runtime
Affected versions: < 7.26.10
Patched version: 7.26.10
Any chance we can get this merged & published on NPM?