Skip to content

Conversation

@marcelpanse
Copy link

@marcelpanse marcelpanse commented Apr 30, 2025

Package: @babel/runtime
Affected versions: < 7.26.10
Patched version: 7.26.10

Any chance we can get this merged & published on NPM?

@jdalrymple
Copy link
Contributor

What is remaining for this ?

@marcelpanse
Copy link
Author

This project looks pretty dead, unfortunately. The last commit was 2 years ago. 😒

@Berkmann18
Copy link
Member

This project looks pretty dead, unfortunately. The last commit was 2 years ago. 😒

It's very hard to maintain a project that big when most of the core maintainers move on or can't find time to maintain it (and then it's down to a single person for a long time). I'm in a slightly better place now (although I still have loads on my plate that will make finding time and energy for OSS stuff a challenge), but hopefully the people who came forward and expressed interest in helping will get this project back on track.

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, hovewer the commit doesn't follow the Angular commit convention so the commit message and PR title would need to be updated.

@jdalrymple
Copy link
Contributor

@marcelpanse Do you mind updating the PR title and commit message to something like: "fix: update dependencies to address security issue in @babel/runtime < 7.26.10"

@marcelpanse marcelpanse changed the title Update packages because of security issue in babel fix: update dependencies to address security issue in @babel/runtime < 7.26.10 Sep 2, 2025
@jdalrymple
Copy link
Contributor

Looks like we need to update the min node version from 16 to 18, is that doable?

@jdalrymple
Copy link
Contributor

I dont have the permissions, but the solution here is to update the engine.node version to 22 (current lts) and the nvmrc file also to 22.14.0

@jdalrymple
Copy link
Contributor

I went and made a duplicate PR #375, i tried to address all the primary issues i was seeing when running the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants