Skip to content

fix(nunit, xunit): exclude redundant data from display names and testMethod #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delatrie merged 3 commits into from
Aug 13, 2025
Merged

fix(nunit, xunit): exclude redundant data from display names and testMethod #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66916db
fix(xunit): preclude ns, class, and params from titles
delatrie Aug 11, 2025
05211c1
fix(nunit): preclude args from default test names
delatrie Aug 11, 2025
43e700a
feat(xunit): exclude params and args from testMethod
delatrie Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Allure.NUnit/Core/AllureNUnitHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ internal static TestResult CreateTestResult(ITest test)
{
var testResult = new TestResult
{
name = test.Name,
name = ResolveDisplayName(test),
titlePath = EnumerateNamesFromTestFixtureToRoot(test).Reverse().ToList(),
labels = new List<Label>
{
Expand Down Expand Up @@ -135,6 +135,13 @@ TestStatus.Failed when IsBroken(result) => Status.broken,
};
}

static string ResolveDisplayName(ITest test) =>
test.Parent switch
{
ParameterizedMethodSuite suite => suite.Name,
_ => test.Name,
};

static IEnumerable<string> EnumerateNamesFromTestFixtureToRoot(ITest test)
{
for (ITest suite = GetTestFixture(test); suite is not null; suite = suite.Parent)
Expand Down
12 changes: 7 additions & 5 deletions Allure.Xunit/AllureXunitHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ string displayName
Label.Language(),
Label.Framework("xUnit.net"),
Label.TestClass(testMethod.TestClass.Class.Name),
Label.TestMethod(displayName),
Label.TestMethod(testCase.TestMethod.Method.Name),
Label.Package(testMethod.TestClass.Class.Name),
}
};
Expand Down Expand Up @@ -331,11 +331,13 @@ static string NewUuid(string name) =>
string.Concat(Guid.NewGuid().ToString(), "-", name);

static string BuildName(ITestCase testCase) =>
testCase.TestMethod.Method.GetCustomAttributes(
MaybeGetExplicitDisplayName(testCase.TestMethod.Method)
?? testCase.TestMethod.Method.Name;

static string? MaybeGetExplicitDisplayName(IMethodInfo method) =>
method.GetCustomAttributes(
typeof(FactAttribute)
).SingleOrDefault()?.GetNamedArgument<string>(
"DisplayName"
) ?? BuildFullName(testCase);
).SingleOrDefault()?.GetNamedArgument<string>("DisplayName");

static string BuildFullName(ITestCase testCase)
{
Expand Down