refactor: reorganize, use eyre for error handling#17
Draft
uncenter wants to merge 5 commits intoalok8bb:masterfrom
Draft
refactor: reorganize, use eyre for error handling#17uncenter wants to merge 5 commits intoalok8bb:masterfrom
eyre for error handling#17uncenter wants to merge 5 commits intoalok8bb:masterfrom
Conversation
Contributor
Author
|
Currently working on a way to pass the ZipArchiver writer to the download function so that the bytes from the files can be written directly into the zip, solving #16 and #15. Having some trouble with lifetimes, borrowing, strict typing though... will be a bit. Also I'm aware this PR is a monstrosity so I'll try to split it up into smaller chunks/steps after I figure out where I'm going with it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just trying some ideas...