Render error to user if base path reserved [WHIT-2884] #10914
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickpatrickpatrick
force-pushed
the
avoid-accidentally-overwriting-base-path
branch
from
3611a8f to
9de162c
Compare
Base automatically changed from
avoid-accidentally-overwriting-base-path
to
main
December 9, 2025 09:59
patrickpatrickpatrick
force-pushed
the
catch-base-path-exception-and-show-user
branch
2 times, most recently
from
f02d8a6 to
4383c4b
Compare
patrickpatrickpatrick
force-pushed
the
catch-base-path-exception-and-show-user
branch
10 times, most recently
from
a396a17 to
025310d
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
catch-base-path-exception-and-show-user
branch
3 times, most recently
from
5ddabe7 to
7e59046
Compare
patrickpatrickpatrick
changed the title
Instead of presenting a server error to the user if they try and create an edition that has the base path of another published edition, the error is now presented to the user.
patrickpatrickpatrick
force-pushed
the
catch-base-path-exception-and-show-user
branch
from
7e59046 to
e9c11b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When trying to create a document that has an already reserved base path, catch the error and render an error with the title field on the new document form.
Why
Continues the work of #10912, now presenting an error to the user. It uses the
construct_similar_slug_warning_errorhelper method as the error message and invalid field are applicable here.Visual Differences
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.