Skip to content

Conversation

@riscait
Copy link
Member

@riscait riscait commented Nov 19, 2024

🙌 What's Done

  • Added keywords for iOS/macOS Spotlight
    • kMDItemKeywords for iOS
    • MDItemKeywords for macOS

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@riscait riscait requested a review from a team as a code owner November 19, 2024 00:17
@riscait riscait requested review from boywithdv and removed request for a team November 19, 2024 00:17
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e02e8b4). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage        ?   23.75%           
=======================================
  Files           ?       13           
  Lines           ?      160           
  Branches        ?        0           
=======================================
  Hits            ?       38           
  Misses          ?      122           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02e8b4...76294fc. Read the comment docs.

---- 🚨 Try these New Features:

@riscait
Copy link
Member Author

riscait commented Nov 19, 2024

@boywithdv
Thanks for the review!
I've taken your suggestion and modified it, so please re-review!

@riscait riscait requested a review from boywithdv November 19, 2024 02:01
Copy link
Contributor

@boywithdv boywithdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the correction!
LGTM!

@riscait riscait merged commit df0bc67 into main Nov 21, 2024
8 checks passed
@riscait riscait deleted the add-keywords-for-spotlight branch November 21, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants