Added support for creating multiple RC files#121
Open
wazoo wants to merge 1 commit intoalup:masterfrom
wazoo:multiple-rcfile
Open
Added support for creating multiple RC files#121wazoo wants to merge 1 commit intoalup:masterfrom wazoo:multiple-rcfile
wazoo wants to merge 1 commit intoalup:masterfrom
wazoo:multiple-rcfile
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a situation when installing gitlab using sbadia/puppet-gitlab that I needed to create multiple RC files (I don't remember the reason) so I extended shrc file creation here.
This uses the .each iterator that is part of the language now but may break backwards comparability, I don't have any older versions of puppet to test with.
I tried to run the spec tests to update those but they fail on the master branch as well so I am not sure whats up with that but master and this branch both had the same 17 failures.