Skip to content

Conversation

zhukaihan
Copy link
Collaborator

@zhukaihan zhukaihan commented Sep 29, 2025

Fix tests' assertions to only assert evaluationId to be there if expected contains it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses inconsistencies in test assertions by introducing a custom assertion helper function to handle the non-deterministic evaluationId field in variant metadata during testing.

  • Adds assertVariantEquals helper function to ignore the evaluationId field when comparing variants
  • Replaces all direct Assert.assertEquals calls for variant comparisons with the new helper function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zhukaihan zhukaihan merged commit 755b419 into main Oct 7, 2025
5 checks passed
@zhukaihan zhukaihan deleted the fix-tests-extra-metadata branch October 7, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants