feat(experiment):Add support for overriding AmplitudeIntegrationPlugin timeout #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of only defaulting to 10s
|
✅ No documentation updates required. |
tyiuhc
force-pushed
the
main
branch
2 times, most recently
from
9b7ade3 to
228cc23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation
experiment.fetch()always takes 10 seconds before finishing.Having it configurable, or defaulting to the same value as
fetchTimeoutMillisat least lets the user have some more control over how much time to wait forfetchto finish.Summary
Sets timeout for
AmplitudeIntegrationPlugintoExperimentConfig.fetchTimeoutMillisif set, or else defaults to 10s as todayChecklist