AD8366 Driver upstream update#3026
Open
rodrigo455 wants to merge 24 commits intomirror_ci/jic23/iio/testingfrom
Open
AD8366 Driver upstream update#3026rodrigo455 wants to merge 24 commits intomirror_ci/jic23/iio/testingfrom
rodrigo455 wants to merge 24 commits intomirror_ci/jic23/iio/testingfrom
Conversation
378f2b8 to
df90254
Compare
573459b to
3982c2b
Compare
nunojsa
reviewed
Nov 24, 2025
Collaborator
nunojsa
left a comment
There was a problem hiding this comment.
You should still add your sob tag for Michael's patches. If you actually change them in any meaningful way you should add co-authored-by tag. See git log for examples
df90254 to
02e319f
Compare
7770c62 to
7dea437
Compare
c477eb9 to
289f20e
Compare
739b23a to
b7877f6
Compare
nunojsa
reviewed
Jan 18, 2026
Collaborator
nunojsa
left a comment
There was a problem hiding this comment.
Just some minor stuff. Feel free to send the patches
| F: Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml | ||
| F: drivers/iio/adc/ad7780.c | ||
|
|
||
| ANALOG DEVICES INC AD8366 DRIVER |
Collaborator
There was a problem hiding this comment.
Not really related to the change but on the commit message replace: s/fragment/entry
| * HMC1119 0.25 dB LSB, 7-Bit, Silicon Digital Attenuator | ||
| * | ||
| * Copyright 2012-2019 Analog Devices Inc. | ||
| * Copyright 2012-2026 Analog Devices Inc. |
Collaborator
There was a problem hiding this comment.
Could mention this change in the commit message
| .gain_max = 20500, | ||
| .gain_step = 253, | ||
| .num_channels = 2, | ||
| .pack_code = ad8366_pack_code, |
Collaborator
There was a problem hiding this comment.
Note that given that you're doing the above, you might be asked to ditch the array in favor of dedicated variables (that is the preferred way in IIO).
e190231 to
bcd2803
Compare
396e400 to
8d2354d
Compare
f8b3189 to
dbccd17
Compare
dbccd17 to
fac29e6
Compare
fac29e6 to
8540152
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This series modernizes the AD8366 amplifier/attenuator driver and adds support for additional device variants.
Device Tree Support:
PR Type
PR Checklist