Skip to content

AD8366 Driver upstream update#3026

Open
rodrigo455 wants to merge 24 commits intomirror_ci/jic23/iio/testingfrom
staging/jic23_iio_ad8366-update
Open

AD8366 Driver upstream update#3026
rodrigo455 wants to merge 24 commits intomirror_ci/jic23/iio/testingfrom
staging/jic23_iio_ad8366-update

Conversation

@rodrigo455
Copy link
Collaborator

@rodrigo455 rodrigo455 commented Nov 21, 2025

PR Description

This series modernizes the AD8366 amplifier/attenuator driver and adds support for additional device variants.

  • Adds support for HMC271 (legacy/obsolete part maintained in ADI tree)
  • Adds support for multiple digital step attenuators:
  • ADRF5720: 0.5 dB LSB, 6-Bit, Digital Attenuator, 9 kHz to 40 GHz
  • ADRF5730: 0.5 dB LSB, 6-Bit, Digital Attenuator, 100 MHz to 40 GHz
  • ADRF5731: 2 dB LSB, 4-Bit, Digital Attenuator, 100 MHz to 40 GHz
  • HMC1018A: 1.0 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz
  • HMC1019A: 0.5 dB LSB GaAs MMIC 5-BIT DIGITAL ATTENUATOR, 0.1 - 30 GHz

Device Tree Support:

  • Adds device tree binding documentation
  • Adds device tree compatible strings for all supported devices

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@rodrigo455 rodrigo455 marked this pull request as draft November 21, 2025 16:56
@rodrigo455 rodrigo455 force-pushed the staging/jic23_iio_ad8366-update branch from 378f2b8 to df90254 Compare November 21, 2025 17:08
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 3 times, most recently from 573459b to 3982c2b Compare November 23, 2025 23:59
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still add your sob tag for Michael's patches. If you actually change them in any meaningful way you should add co-authored-by tag. See git log for examples

@rodrigo455 rodrigo455 force-pushed the staging/jic23_iio_ad8366-update branch from df90254 to 02e319f Compare November 24, 2025 18:09
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 7 times, most recently from 7770c62 to 7dea437 Compare November 30, 2025 23:59
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 5 times, most recently from c477eb9 to 289f20e Compare December 5, 2025 23:59
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 5 times, most recently from 739b23a to b7877f6 Compare January 18, 2026 00:02
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff. Feel free to send the patches

F: Documentation/devicetree/bindings/iio/adc/adi,ad7780.yaml
F: drivers/iio/adc/ad7780.c

ANALOG DEVICES INC AD8366 DRIVER
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to the change but on the commit message replace: s/fragment/entry

* HMC1119 0.25 dB LSB, 7-Bit, Silicon Digital Attenuator
*
* Copyright 2012-2019 Analog Devices Inc.
* Copyright 2012-2026 Analog Devices Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could mention this change in the commit message

.gain_max = 20500,
.gain_step = 253,
.num_channels = 2,
.pack_code = ad8366_pack_code,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that given that you're doing the above, you might be asked to ditch the array in favor of dedicated variables (that is the preferred way in IIO).

@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 7 times, most recently from e190231 to bcd2803 Compare January 25, 2026 00:12
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 8 times, most recently from 396e400 to 8d2354d Compare February 3, 2026 00:02
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch 6 times, most recently from f8b3189 to dbccd17 Compare February 10, 2026 00:07
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch from dbccd17 to fac29e6 Compare February 11, 2026 00:05
@github-actions github-actions bot requested a review from stefpopa as a code owner February 11, 2026 00:05
@github-actions github-actions bot force-pushed the mirror_ci/jic23/iio/testing branch from fac29e6 to 8540152 Compare February 12, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants