Added Corundum support for ADRV9009ZU11EG #3049
Open
+45
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added three new build params. for ZynqMp defconfig to support the Corundum features - As of now, Corundum support is only available for ADRV9009ZU11EG/ADRV2CRR variant of the project - arch: arm64: dts: xilinx: zynqmp-adrv9009-zu11eg-reva-adrv2crr-fmc-reva.dts : added the settings for Corundum to work (they also work with the default project) - arch: arm64: dts: xilixn: zynqmp-adrv9009-zu11eg-revb-adrv2crr-fmc-revb-jesd204-fsm-100-qsfp.dts: the corresponding devicetree Corundum on ADRV9009ZU11EG Signed-off-by: Cristian Mihai Popa <cristianmihai.popa@analog.com>
cristianmihaipopa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
stefpopa
requested changes
Feb 10, 2026
Collaborator
stefpopa
left a comment
stefpopa
left a comment
There was a problem hiding this comment.
A few clarifications are required, otherwise, looks good.
| resets = <&zynqmp_reset 117>; // ZYNQMP_RESET_PS_PL1 | ||
| reset-names = "reset"; | ||
| }; | ||
| }; No newline at end of file |
Collaborator
There was a problem hiding this comment.
you have a missing newline at the end of this file
| assigned-clock-rates = <10000>, <1413120000>, <30720000>; | ||
| <&ad9545_clock AD9545_CLK_PLL AD9545_PLL1>, | ||
| <&ad9545_clock AD9545_CLK_OUT AD9545_Q1B>; | ||
| assigned-clock-rates = <10000>, <1562500000>, <156250000>; |
Collaborator
There was a problem hiding this comment.
your commit does not explain why these changes are needed. Is this a breaking change for the configurations that don't use corundum?
| ad9545_apll0: pll-clk@AD9545_PLL0 { | ||
| reg = <AD9545_PLL0>; | ||
| ad9545_apll1: pll-clk@AD9545_PLL1 { | ||
| reg = <AD9545_PLL1>; |
Collaborator
There was a problem hiding this comment.
same comment as above, this commit does not explain why this change is needed.
| reg = <0x0 0xa0000000 0x1000000>; | ||
| reg-names = "csr"; | ||
| interrupt-parent = <&gic>; | ||
| interrupts = <0 93 1>; |
Collaborator
There was a problem hiding this comment.
This interrupt line is hardcoded. Magic number 93 without explanation, flag value 1 should use symbolic constants
|
|
||
| / { | ||
| model = "Analog Devices ADRV9009ZU11EG Corundum support"; | ||
| /delete-node/ leds; |
Collaborator
There was a problem hiding this comment.
why delete LEDs? Please add an explanation. Is it related to the corundum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Corresponding HDL PR: analogdevicesinc/hdl#1971
PR Type
PR Checklist