Skip to content

Conversation

@eaaltonen
Copy link

@eaaltonen eaaltonen commented Sep 4, 2025

Description

Fix a typo in the BuildRun model and add a method get build runs for a given build_name

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has it been tested ?

Tested get_build_runs with live on-premise Artifactory installation and it returned a list of run uris.

Checklist:

  • My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • All commits have a correct title
  • Readme has been updated
  • Quality tests are green (see Codacy)
  • Automated tests are green (see pipeline)

@eaaltonen eaaltonen force-pushed the build_runs branch 2 times, most recently from 3e617dd to 1581e9e Compare September 5, 2025 11:42
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Just some minor changes are required, but the PR looks good.

@eaaltonen eaaltonen marked this pull request as draft September 5, 2025 20:36
@anancarv
Copy link
Owner

anancarv commented Sep 5, 2025

I can see that the lint job is failing. To fix it, you need to edit the bandit pre-commit like this:

- repo: https://github.com/PyCQA/bandit
      rev: '1.7.4'
      hooks:
      - id: bandit
        args: ["-c", "pyproject.toml"]
        additional_dependencies:
          - "bandit[toml]"
          - "pbr"

@eaaltonen
Copy link
Author

I can see that the lint job is failing. To fix it, you need to edit the bandit pre-commit like this:

- repo: https://github.com/PyCQA/bandit
      rev: '1.7.4'
      hooks:
      - id: bandit
        args: ["-c", "pyproject.toml"]
        additional_dependencies:
          - "bandit[toml]"
          - "pbr"

Thanks. I was unsure of adding pbr since I'm not familiar with it.

@eaaltonen eaaltonen marked this pull request as ready for review September 10, 2025 14:46
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anancarv anancarv merged commit 4be8493 into anancarv:master Sep 10, 2025
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants