Make list-all script non-dependent on python to avoid library/versioning issues #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandofig
changed the title
fernandofig
force-pushed
the
master
branch
2 times, most recently
from
15d188d to
296f7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was done because the
list-allscript (used byasdf list all pipenvcommand) is curerntly failing for modern python versions (tested on 3.12+, not sure about earlier ones). This happens because thepkg_resourceslibrary that's referenced in the inline python script previously used inlist-allhas been deprecated andpackaging.versionreplaced it for newer python versions.But
packaging.versionis now a non-core library, so using it entails adding a required package dependency in order for the plugin to work effectively on newer python versions. To avoid this, I've removed the python logic altogether and replaced it by plain bash + common utils.It's a bit messy and likely vulnerable to changes in PyPi's json format/structure changes, but I figure that's a lesser problem than having to deal with python versioning + library dependencies.