Ensure a single bad message does not cause a thread exception#83
Merged
andreikop merged 1 commit intoandreikop:masterfrom Jan 24, 2025
Merged
Conversation
This was referenced Jan 23, 2025
bdraco
force-pushed
the
prevent_thread_exception_collapse_bad_message
branch
from
978f81f to
345c4a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a single message cannot be parsed and throws, the whole thread would collapse and no more messages would be parsed see exception in #82
Its unfortunately common for poorly built devices to send invalid messages which cannot be parsed. We still want to get messages from working devices on the network.