Python ASR Changes - Allow parameter passthrough to provider SDKs. #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of test cases Core parameter pass-through functionality is fully tested and validated through unit tests and client integration tests. test_asr_params.py - ParamValidator logic, mappings, transformations. test_client.py - Client-level validation, all modes, parameter flow test_asr_parameter_passthrough.py - OpenAI & Google. Deepgram mock test will need more work due to dynamic imports used in the SDK, hence not included in this commit.
Summary - Deepgram SDK v5 code migration Pydantic v2 model serialization fix Test language assertion fix
rohitprasad15
force-pushed
the
rp15/asr-passthrough-api
branch
from
75f21a1 to
c882393
Compare
rohitprasad15
force-pushed
the
rp15/asr-passthrough-api
branch
from
903b9c8 to
38962ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ensuring easy portability across multiple ASR providers, allow parameters to be passed through.
New model gives a choice to developers to get warnings or exception for scenarios where parameters don't apply to a provider.
Added Unit tests for the same.