feat: add Claude Code runner #73
Conversation
Removes a couple of methods that were duplicated from the base class.
Moves the instructions and ignored files into the agent base class.
crisbeto
force-pushed
the
claude-support
branch
from
22f1c66 to
25e5dea
Compare
| '--model', | ||
| MODEL_MAPPING[options.model], | ||
| // Skip all confirmations. | ||
| '--dangerously-skip-permissions', |
There was a problem hiding this comment.
Do we eventually need a warning before selecting some of these runners? seems "corp-risky"?
There was a problem hiding this comment.
Maybe, although internally this wouldn't be installed anyways.
There was a problem hiding this comment.
I thought anybody could run with the claude code runner on a corporate machine and this could execute arbitrary commands?
There was a problem hiding this comment.
Sure, but I meant if we were running in a g3 context.
There was a problem hiding this comment.
ah yeah, I'm mostly talking about it executing on corp machines, so it could technically even reach into other directories?
There was a problem hiding this comment.
I think that it could in theory, but my impression was that it's set up to run in the CWD.
There was a problem hiding this comment.
@crisbeto just to follow-up on this. The risk is that the agent is started in CWD, but can also use tools to read files from e.g. $HOME/.zshrc etc
package.json
Outdated
| "wcs": "./runner/bin/cli.js" | ||
| }, | ||
| "dependencies": { | ||
| "@anthropic-ai/claude-code": "^1.0.128", |
There was a problem hiding this comment.
Should these runners be optional dependencies eventually? (i.e. users install them in their project?)
There was a problem hiding this comment.
Hmm potentially, but how would the type checking work?
There was a problem hiding this comment.
We'd have it as a dev dependency on our end, but not as a runtime dependency for shipping to npm.
There was a problem hiding this comment.
I pushed another commit to make them optional.
Fixes an error I saw while debugging where if the `exit` event emits quickly, we would get a `Cannot access <name> before initialization` error.
Allows for agents inheriting from the `BaseCliAgentRunner` to override the timeout values.
Some agent processes don't seem to execute until stdin has ended. These changes add it to the `BaseCliAgentRunner`.
Adds a runner that generates code using Claude Code.
Reduces the font size of the provider labels so they don't wrap to the next line as often.
crisbeto
force-pushed
the
claude-support
branch
from
25e5dea to
d57309b
Compare
package.json
Outdated
| "wcs": "./runner/bin/cli.js" | ||
| }, | ||
| "dependencies": { | ||
| "@anthropic-ai/claude-code": "^1.0.128", |
There was a problem hiding this comment.
Hmm potentially, but how would the type checking work?
| '--model', | ||
| MODEL_MAPPING[options.model], | ||
| // Skip all confirmations. | ||
| '--dangerously-skip-permissions', |
There was a problem hiding this comment.
Maybe, although internally this wouldn't be installed anyways.
2 participants
Adds a runner that generates code using Claude Code.