Conversation
|
Any updates on getting this pulled in? |
|
Checking in on getting this merged into master again! Would really love to see it. |
|
This will not get merged, unless the issue on Windows is solved. |
t0rr3sp3dr0
left a comment
t0rr3sp3dr0
left a comment
There was a problem hiding this comment.
Would these suggested changes be enough to get this PR merged?
I need an answer for #239 (comment). |
akihikodaki
force-pushed
the
macos
branch
6 times, most recently
from
344c91e to
d1e471b
Compare
|
This pull request should be now ready for reviews by maintainers. |
|
@ebassi please take a second look. |
|
@ebassi Hi, it's been three years since this was submitted. Can you take a look at this? |
|
Two minor changes to limit DLL checks on Windows. |
Applied with commit b0d6d60. |
|
9fdedad: Replaced |
|
@ebassi could you please approve this workflow? |
|
What's the current status of this? |
|
It seems all the feedback was addressed. Is something pending here? Would love to see this merged. |
Now it automatically finds files from Qt 5 and supports the upstream ANGLE on Windows and macOS.
|
Based on feedback from @mohd-akram, commit 47d975d simplifies the code by assuming modern ANGLE. |
ebassi
left a comment
ebassi
left a comment
There was a problem hiding this comment.
Not super happy about having to check for Qt, but that's them breaks, I guess…
10 participants
No description provided.