Allow customizing parent controller of Blazer::BaseController#473
Open
grk wants to merge 3 commits intoankane:masterfrom
Open
Allow customizing parent controller of Blazer::BaseController#473grk wants to merge 3 commits intoankane:masterfrom
grk wants to merge 3 commits intoankane:masterfrom
Conversation
|
Great feature and very simple implementation. @ankane Is there any blocker? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the problem of having admin user auth methods defined on a controller that inherits from ApplicationController, and thus being unable to properly secure blazer.
This PR (or more like a draft to start a discussion) adds an ability to customize that.
By default it will behave as before, inheriting from ApplicationController, but it's customizable in
Settings['base_controller'].