Added support for in-statement variable annotations.#512
Open
Jack12816 wants to merge 1 commit intoankane:masterfrom
Open
Added support for in-statement variable annotations.#512Jack12816 wants to merge 1 commit intoankane:masterfrom
Jack12816 wants to merge 1 commit intoankane:masterfrom
Conversation
Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
Author
|
@ankane Ping? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First things first: thank you all very much for this awesome gem! 🙏
- What is it good for
In my company and use case, the people who write and maintain queries in Blazer are not the ones running them, and neither of these groups maintains the Blazer configuration or deploys the application. Smart variables would be useful, but they require configuration changes and deployments. Simple variables are great, but they result in free-text inputs. The people running the queries are not always technical, so it would be helpful if we could annotate variable values so that, instead of free-text inputs, they see select boxes with valid options.
This PR adds a solution for this:
- What I did
I just added a
Blazer::Statement#variable_valuesmethod which searches for comments on the statement in a particular format, tries to parse them as JSON, and uses them for displaying on the UI.- A picture of a cute animal (not mandatory but encouraged)
