Fix: allow blank data source URL in test environment#519
Closed
Mallik544 wants to merge 3 commits intoankane:masterfrom
Closed
Fix: allow blank data source URL in test environment#519Mallik544 wants to merge 3 commits intoankane:masterfrom
Mallik544 wants to merge 3 commits intoankane:masterfrom
Conversation
Owner
|
Hi @Mallik544, see #518. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
System specs fail because
adapter_instanceraisesEmpty url for data source: mainin test environment.Cause
The current condition allows a blank URL in development, but not in test.
Fix
Allow
Rails.env.test?to bypass the URL requirement.Result
This aligns test behavior with development and prevents unnecessary failures in system specs.