fix: use year-based slug matching for Metacritic (fixes wrong matches for X 2022) #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a developer, and I have only tested it locally with the movie X (2022).
Further review and testing by maintainers is required before merging.
What
Fix Metacritic provider to try year-specific slugs first (e.g.,
/movie/x-2022), then fall back to plain slug, then a secondary year suffix. This avoids landing on the wrong film for ambiguous titles.Why
Movies with shared names (e.g., X (2022)) were resolving to incorrect Metacritic pages when the URL lacked the year, causing wrong or missing ratings.
How
${BASE_URL}/${mediaType}/${slug}-${year}${BASE_URL}/${mediaType}/${slug}${BASE_URL}/${mediaType}/${slug}-${year}-2yearfromstreamInfo.year(orstreamInfo.dateupstream).Impact
yearis consistently passed through, which may indirectly improve other providers.Testing
tt13560574).Files
src/providers/metacritic.js(slug logic + multi-URL attempts)