Added new helpers for square root, word count, random string #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djunehor
commented
Oct 2, 2019
djunehor
commented
- helper function to return square root of a number
- helper function to count number of words in a word
- helper function to split a string to an array
- helper function to return random string of specified length
anoniscoding
reviewed
Oct 7, 2019
| * | ||
| * @returns {number} | ||
| */ | ||
| function nombalasan (args) { |
Owner
There was a problem hiding this comment.
Please use camel casing. nonbaLasan
| * | ||
| * @returns {number} | ||
| */ | ||
| function igunmerin (args) { |
Owner
There was a problem hiding this comment.
Please use camel casing. square root is Irìn kejì in yoruba
| @@ -0,0 +1,18 @@ | |||
| /** Takes any number | |||
Owner
There was a problem hiding this comment.
Please add test cases for each of these methods
| var result = ""; | ||
| var characters = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; | ||
| var charactersLength = characters.length; | ||
| for (var i = 0; i < length; i++) { |
Owner
There was a problem hiding this comment.
Please use let for block variables
| */ | ||
| function yipooro (args) { | ||
| if (Array.isArray(args)) { | ||
| let [ length, ] = args; |
Owner
There was a problem hiding this comment.
const is preferred in yorlang codebase whenever a variable is not re-assigned
| * | ||
| * @returns {number} | ||
| */ | ||
| function iyeoro (args) { |
| * @param {string} str - receives a string and returns the length | ||
| * @returns number | ||
| */ | ||
| function pipoto (args) { |
Owner
There was a problem hiding this comment.
There's already an helper method ka that does this
Author
There was a problem hiding this comment.
The existing helper function ka is to count number of elements in an array. This helper pipoto is to count the length of a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.