Skip to content

Conversation

@rivv0
Copy link
Contributor

@rivv0 rivv0 commented Oct 1, 2025

Updated the galaxy.json schema used by ansible-lint to remove the repository key from the list of required properties for galaxy.yml. According to the [Collection Galaxy metadata structure], the repository key is optional and should not trigger a schema violation.

  • ansible-lint will no longer fail with a schema error when repository is missing from galaxy.yml.
  • Developers will receive a warning (if the new rule is enabled) rather than a blocking error.
  • Improves compatibility with the official Ansible Galaxy metadata specification and the VS Code Ansible extension.

Fixes: #4793

@rivv0 rivv0 requested a review from a team as a code owner October 1, 2025 12:31
@rivv0 rivv0 changed the title #4793 Updating schema definition so it doesnot show "repository" key required in "galaxy.yml" fix #4793 Updating schema definition so it doesnot show "repository" key required in "galaxy.yml" Oct 4, 2025
@ssbarnea ssbarnea added the fix label Oct 7, 2025
@github-actions github-actions bot added fix and removed fix labels Oct 7, 2025
@ssbarnea ssbarnea changed the title fix #4793 Updating schema definition so it doesnot show "repository" key required in "galaxy.yml" fix: make repository key optional in galaxy.yml Oct 7, 2025
@alisonlhart
Copy link
Contributor

@rivv0 Thanks for this contribution! It looks great. We just need the tests updated to accommodate the change. Can you make the needed changes (add LICENSE to fixtures) and then we can get this merged. We will wait for final approval until then, but I don't have any concerns outside of the tests.

Copy link
Contributor

@alisonlhart alisonlhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fixtures need a LICENSE file for the new check.

@github-project-automation github-project-automation bot moved this from Review to In Progress in 🧰 devtools project board Oct 8, 2025
@rivv0
Copy link
Contributor Author

rivv0 commented Oct 8, 2025

yes would do that.

@github-actions github-actions bot added the fix label Oct 23, 2025
@github-actions github-actions bot added fix and removed fix labels Oct 23, 2025
@alisonlhart alisonlhart merged commit 5a74f30 into ansible:main Oct 23, 2025
20 of 21 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧰 devtools project board Oct 23, 2025
@github-actions github-actions bot added fix and removed fix labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ansible-lint requires "repository" key to exist in "galaxy.yml" although "repository" is not syntactically required.

3 participants