-
Notifications
You must be signed in to change notification settings - Fork 706
fix: make repository key optional in galaxy.yml #4798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rivv0 Thanks for this contribution! It looks great. We just need the tests updated to accommodate the change. Can you make the needed changes (add LICENSE to fixtures) and then we can get this merged. We will wait for final approval until then, but I don't have any concerns outside of the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fixtures need a LICENSE file for the new check.
|
yes would do that. |
Updated the galaxy.json schema used by ansible-lint to remove the repository key from the list of required properties for galaxy.yml. According to the [Collection Galaxy metadata structure], the repository key is optional and should not trigger a schema violation.
Fixes: #4793