Skip to content

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 29, 2025

As testinfra is already using --connection argument, we will only recognize --ansible-connection variant from now on, so we do not end-up with conflicts.

To avoid confusing error messages, fail fast if testinfra plugin is detected.

As testinfra is already using `--connection` argument, we will only
recognize `--ansible-connection` variant from now on, so we do not
endup with conflicts.
@github-actions github-actions bot added the fix label Sep 29, 2025
@ssbarnea ssbarnea marked this pull request as ready for review September 29, 2025 08:51
@ssbarnea ssbarnea requested a review from a team as a code owner September 29, 2025 08:51
@ssbarnea ssbarnea closed this Sep 29, 2025
@ssbarnea ssbarnea reopened this Sep 29, 2025
@github-actions github-actions bot removed the fix label Sep 29, 2025
@ssbarnea ssbarnea changed the title fix: remove --connection argument to avoid conflict with testinfra fix: fail fast if testinfra plugin is detected Sep 29, 2025
@github-actions github-actions bot added the fix label Sep 29, 2025
To avoid confusing error messages, fail fast if testinfra plugin
is detected.

- #509
- pytest-dev/pytest-testinfra#58
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we fail fast, why the breaking removal of connection?

@github-project-automation github-project-automation bot moved this from Review to In Progress in 🧰 devtools project board Sep 29, 2025
@alisonlhart alisonlhart marked this pull request as draft October 22, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants