Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Preview failed

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在为组件提供统一的自定义 CSS 类前缀机制。通过在 ConfigProvider 中引入 prefixCls 属性和 getPrefixCls 方法,开发者可以全局配置组件的类前缀,同时允许单个组件通过自身的 prefixCls 属性进行局部覆盖。这一改进使得主题定制和样式隔离更加灵活和一致,解决了相关 issue #6960 中提到的问题。

Highlights

  • ActionSheet 组件类前缀自定义: ActionSheet 组件现在支持通过 prefixCls 属性自定义其 CSS 类前缀,增强了组件的样式灵活性。
  • ConfigProvider 统一类前缀管理: ConfigProvider 引入了 getPrefixCls 方法,用于统一管理组件的类前缀,并增加了 prefixCls 属性,允许全局设置所有子组件的类前缀。
  • 组件内部类名生成逻辑更新: ActionSheet 组件内部已更新,使用 ConfigProvider 提供的 getPrefixCls 方法来动态生成其类名,取代了硬编码的类前缀。
  • 新增和更新测试用例: 新增了测试用例,以验证 ConfigProvider 和组件级别的 prefixCls 自定义功能,并更新了 useConfig 的测试,确保 getPrefixCls 方法被正确暴露。
  • 文档更新: 英文和中文文档都已更新,增加了 ConfigProvider 的 prefixCls 属性说明,方便开发者了解和使用新功能。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the feature label Oct 21, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 统一了为组件提供自定义 prefixCls 的方式,做得很好。通过在 ConfigProvider 中添加 prefixClsgetPrefixCls,实现了全局的 CSS 类名前缀配置。同时,在 ActionSheet 组件级别也支持了 prefixCls 属性,并正确处理了优先级。代码变更清晰,并且添加了相应的单元测试来覆盖新功能。

我只在 config-provider.tsx 中发现一处轻微的代码重复,并提供了一个重构建议以提高代码的可维护性。

Comment on lines 85 to 92
const getPrefixCls = (suffixCls?: string, customizePrefixCls?: string) => {
if (customizePrefixCls) {
return customizePrefixCls
}
const mergedPrefixCls =
config.prefixCls || parentConfig.prefixCls || defaultPrefixCls
return suffixCls ? `${mergedPrefixCls}-${suffixCls}` : mergedPrefixCls
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

此处的 getPrefixCls 函数与文件顶部定义的版本(第 52-57 行)存在代码重复。为了提高代码的可维护性,建议将通用逻辑提取到一个辅助函数中。

例如,可以创建一个生成器函数:

const genGetPrefixCls = (basePrefix: string) => (suffixCls?: string, customizePrefixCls?: string) => {
  if (customizePrefixCls) return customizePrefixCls;
  return suffixCls ? `${basePrefix}-${suffixCls}` : basePrefix;
};

然后,defaultConfigRefConfigProvider 组件都可以使用这个生成器来创建各自的 getPrefixCls 函数,从而消除重复代码。

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6962

commit: 60631cd

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (60631cd).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6962   +/-   ##
========================================
  Coverage    92.95%   92.95%           
========================================
  Files          337      337           
  Lines         7368     7370    +2     
  Branches      1871     1861   -10     
========================================
+ Hits          6849     6851    +2     
  Misses         483      483           
  Partials        36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EmilyyyLiu EmilyyyLiu force-pushed the feature-prefix-actionSheet branch from 98a7c92 to 6096c95 Compare October 23, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant