Skip to content

IOS-5312 Toggles | Delete binScreenEmptyAction #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

IOS-5312 Toggles | Delete binScreenEmptyAction #4076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Anytype/Sources/PresentationLayer/Flows/EditorFlow/EditorCoordinatorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@ struct EditorCoordinatorView: View {
case let .recentOpen(spaceId):
WidgetObjectListRecentOpenView(spaceId: spaceId, output: model)
case let .bin(spaceId):
if FeatureFlags.binScreenEmptyAction {
BinListView(spaceId: spaceId, output: model)
} else {
WidgetObjectListBinView(spaceId: spaceId, output: model)
}
BinListView(spaceId: spaceId, output: model)
case let .page(data):
EditorPageCoordinatorView(data: data, showHeader: true, setupEditorInput: { _, _ in })
case let .list(data):
Expand Down
24 changes: 0 additions & 24 deletions Anytype/Sources/PresentationLayer/Modules/WidgetObjectList/Bin/WidgetObjectListBinView.swift
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions ...Sources/PresentationLayer/Modules/WidgetObjectList/Bin/WidgetObjectListBinViewModel.swift
View file
Open in desktop

This file was deleted.

38 changes: 0 additions & 38 deletions Anytype/Sources/ServiceLayer/Subscriptions/BinSubscriptionService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ protocol BinSubscriptionServiceProtocol: AnyObject, Sendable {

var dataSequence: AnyAsyncSequence<[ObjectDetails]> { get async }

func legacyStartSubscription(
spaceId: String,
objectLimit: Int?,
update: @escaping @MainActor ([ObjectDetails]) -> Void
) async

func startSubscription(spaceId: String, objectLimit: Int?, name: String?) async

func stopSubscription() async
Expand All @@ -36,38 +30,6 @@ actor BinSubscriptionService: BinSubscriptionServiceProtocol {
return subscriptionStorage.statePublisher.map { $0.items }.values.eraseToAnyAsyncSequence()
}

func legacyStartSubscription(
spaceId: String,
objectLimit: Int?,
update: @escaping @MainActor ([ObjectDetails]) -> Void
) async {

let sort = SearchHelper.sort(
relation: BundledPropertyKey.lastModifiedDate,
type: .desc
)

let filters: [DataviewFilter] = .builder {
SearchHelper.notHiddenFilters(isArchive: true)
}

let searchData: SubscriptionData = .search(
SubscriptionData.Search(
identifier: subscriptionId,
spaceId: spaceId,
sorts: [sort],
filters: filters,
limit: objectLimit ?? Constants.limit,
offset: 0,
keys: BundledPropertyKey.objectListKeys.map { $0.rawValue }
)
)

try? await subscriptionStorage.startOrUpdateSubscription(data: searchData) { data in
await update(data.items)
}
}

func startSubscription(spaceId: String, objectLimit: Int?, name: String?) async {
let sort = SearchHelper.sort(
relation: BundledPropertyKey.lastModifiedDate,
Expand Down
5 changes: 0 additions & 5 deletions Modules/AnytypeCore/AnytypeCore/Generated/FeatureFlags+Flags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
public extension FeatureFlags {

// Static value reader
static var binScreenEmptyAction: Bool {
value(for: .binScreenEmptyAction)
}

static var muteSpacePossibility: Bool {
value(for: .muteSpacePossibility)
}
Expand Down Expand Up @@ -144,7 +140,6 @@ public extension FeatureFlags {

// All toggles
static let features: [FeatureDescription] = [
.binScreenEmptyAction,
.muteSpacePossibility,
.addNotificationsSettings,
.swipeToReply,
Expand Down
6 changes: 0 additions & 6 deletions Modules/AnytypeCore/AnytypeCore/Utils/FeatureFlags/FeatureDescription+Flags.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@ import Foundation

public extension FeatureDescription {

static let binScreenEmptyAction = FeatureDescription(
title: "Bin screen - empty action",
type: .feature(author: "[email protected]", releaseVersion: "13"),
defaultValue: true
)

static let muteSpacePossibility = FeatureDescription(
title: "Mute space possibility",
type: .feature(author: "[email protected]", releaseVersion: "13"),
Expand Down