feature: toast popup when you queue#900
Open
chris90483 wants to merge 4 commits intoaome510:masterfrom
Open
Conversation
Contributor
|
@chris90483 maybe you can provide a screenshot and a description of the feature you drafted? |
…ault for frames_left and got the disappearing of the popup working
chris90483
changed the title
Author
|
Hi @mgumz, thanks for your reply. The feature now works as intended so this PR is no longer in draft. Description of the feature: When you add a track to the queue (with shift + z), the application adds it to your queue silently. This PR changes this behavior by making a "toast" popup appear when a track gets added to the queue. The toast popup dismisses itself automatically after some time (I implemented a default duration in the app config). You can see a little demo here: https://youtu.be/W4txYkqaxIc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the feature: When you add a track to the queue (with shift + z), the application adds it to your queue silently. This PR changes this behavior by making a "toast" popup appear when a track gets added to the queue. The toast popup dismisses itself automatically after some time (I implemented a default duration in the app config).
You can see a little demo here: https://youtu.be/W4txYkqaxIc