fix: correct disable_thoughts logic in system prompt#51
Open
Aoi-cn wants to merge 1 commit intoaorwall:mainfrom
Open
fix: correct disable_thoughts logic in system prompt#51Aoi-cn wants to merge 1 commit intoaorwall:mainfrom
Aoi-cn wants to merge 1 commit intoaorwall:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the logic in
moatless-tools/moatless/completion/react.py:44 - 52is conflicting with the check logic inmoatless-tools/moatless/completion/react.py:146 - 151After comparing, I think the logic in 146-151 might be the right one, so I took the liberty to modify the above logic, I don't know if the modification is correct.