Skip to content

Conversation

@mlohvynenko
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 78.09524% with 23 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (e365ad0) to head (56c8c0c).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/common/crypto/openssl/cryptoprovider.cpp 56.52% 10 Missing ⚠️
src/iam/certmodules/pkcs11/pkcs11.cpp 70.00% 6 Missing ⚠️
src/common/crypto/mbedtls/cryptoprovider.cpp 88.00% 3 Missing ⚠️
src/iam/permhandler/permhandler.cpp 88.23% 2 Missing ⚠️
src/sm/launcher/launcher.cpp 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #316      +/-   ##
===========================================
- Coverage    82.26%   82.21%   -0.05%     
===========================================
  Files          169      169              
  Lines        17239    17268      +29     
  Branches      2319     2324       +5     
===========================================
+ Hits         14181    14197      +16     
- Misses        3058     3071      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch from bfbdd24 to e75990d Compare May 22, 2025 07:40
@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch from e75990d to 87dc775 Compare May 22, 2025 15:16
@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch from 87dc775 to 7244390 Compare June 4, 2025 14:28
@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch 2 times, most recently from 3851dd2 to 36cb93f Compare June 25, 2025 10:21
Copy link
Collaborator

@al1img al1img left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Oleksandr Grytsov <[email protected]>

@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch from 36cb93f to 7a8be73 Compare July 2, 2025 15:16
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch removes CreateUUID free function and
replaces it with calls to the crypto provider interface.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
@mlohvynenko mlohvynenko force-pushed the feature_improve_uuid branch from 7a8be73 to 56c8c0c Compare July 2, 2025 19:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
39.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@al1img al1img merged commit 547591b into aosedge:develop Jul 3, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants