Skip to content

Conversation

@mlohvynenko
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.32%. Comparing base (6730f67) to head (865b865).
⚠️ Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
src/sm/launcher/launcher.cpp 11.76% 15 Missing ⚠️
src/sm/launcher/instance.cpp 77.77% 2 Missing ⚠️
tests/include/mocks/resourcemanagermock.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
+ Coverage    82.30%   82.32%   +0.02%     
===========================================
  Files          171      172       +1     
  Lines        17360    17374      +14     
  Branches      2333     2343      +10     
===========================================
+ Hits         14288    14303      +15     
+ Misses        3072     3071       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlohvynenko mlohvynenko force-pushed the feature_cm_cloud_message branch from 1666d79 to 256060d Compare July 11, 2025 12:07
@mlohvynenko mlohvynenko marked this pull request as draft July 11, 2025 12:07
@mlohvynenko mlohvynenko force-pushed the feature_cm_cloud_message branch 17 times, most recently from 560a5e8 to e7e0187 Compare July 22, 2025 13:39
@mlohvynenko mlohvynenko marked this pull request as ready for review July 23, 2025 07:31
@mlohvynenko mlohvynenko force-pushed the feature_cm_cloud_message branch from e7e0187 to 2529b1c Compare July 23, 2025 07:34
@mlohvynenko mlohvynenko force-pushed the feature_cm_cloud_message branch 7 times, most recently from afaa717 to 99e804b Compare July 25, 2025 12:43
@mykola-kobets-epam
Copy link
Contributor

Reviewed-by: Mykola Kobets <[email protected]>

This patch enhances the usability of the EnumStringer class
in constant expressions.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds failed item status enum value.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch updates cloud message type enum with all
supported values.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch aligns the instance status structure with
the cloud protocol.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch defines monitoring message from the cloud protocol.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch removes redundant log message type enum
as cloud protocol message type enum contains these values.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch aligns the request log message with the cloud protocol:
- Upload options are moved out from the log filter
to the request log message;
- Log type is changed to log upload type in the upload options struct.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds alerts cloud message structure.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch defines a constant for the maximum number
of certificate chains.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch implements certificates cloud protocol messages.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch moves the bearer token length constant
to the types header to make it more accessible.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds support for cloud protocol
environment variables messages.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds structures that represents messages
received and sent by the cloud.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch updates communication interface to have a single method
for sending messages that will accept variant type of cloud message.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds an interface that is capable of handling messages
received from by the communication module.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
sha3 224 constant holds size of a byte array, this patch
multiplies it by 2 to hold a hex representation of the checksum
in a static string object.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds an ability to specify the number of
parallel jobs for the build process using
the --parallel option in the build.sh script.
This allows users to optimize build times based on
their system's capabilities.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch moves unit status structure to the cloudprotocol module
and updates unit status structure usages in source code.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds unit config structure to the cloud protocol.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds the desired status message to the cloud protocol.
In this patch, only the unit config field of the desired status
message is added.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
@mlohvynenko mlohvynenko force-pushed the feature_cm_cloud_message branch from fafe708 to 865b865 Compare July 29, 2025 09:42
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
41.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mlohvynenko mlohvynenko merged commit 90c27a0 into aosedge:develop Jul 29, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants