Launcher implementation #342

mykola-kobets-epam · 2025-07-24T16:43:17Z

No description provided.

This patch adds a new identifier pool utility to the common tools library. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch adds cloudprotocol state structures. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch adds storage state interfaces to the cm module. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch makes it possible to use instance ident with STL containers that require a less operator. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch adds support for the SHA3-224 hash algorithm in the crypto provider. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch enhances the platform filesystem interface by adding a method to set user quota. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch removes the redundant definition of the SHA1 digest size in the configuration header file. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

This patch adds a new communication interface to the cm module with API needed for storage state module. Signed-off-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

Signed-off-by: Mykola Solianko <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

Signed-off-by: Mykola Kobets <[email protected]>

InstanceIdent-s should be sorted by service, then subject, then instance ind. Signed-off-by: Mykola Kobets <[email protected]>

Signed-off-by: Mykola Kobets <[email protected]>

al1img · 2025-08-07T09:19:39Z

include/aos/common/ocispec/serviceconfig.hpp

+/**
+ * Max number of allowed connections.
+ */
+static constexpr auto cMaxNumConnections = AOS_CONFIG_NETWORKMANAGER_CONNECTIONS_PER_INSTANCE_MAX_COUNT;


I guess we have to rename config options to
AOS_CONFIG_CONNECTIONS_PER_INSTANCE_MAX_COUNT
AOS_CONFIG_CONNECTION_NAME_LEN
accordingly. And create appropriate consts int types.hpp then use these consts for NetworkManager and spec.

al1img · 2025-08-07T09:21:07Z

include/aos/common/tools/identifierpool.hpp

@@ -113,6 +113,20 @@ class IdentifierRangePool : public NonCopyable {
        return ErrorEnum::eNone;
    }

+    /**
+     * Clear identifier in pool.


al1img · 2025-08-07T09:22:47Z

include/aos/common/tools/algorithm.hpp

+     * @param value value to check for existence.
+     * @return bool.
+     */
+    bool Exist(const T& value) const { return Find(value) != end(); }


Just wrapper around Find and FindIf. Do we need it?

al1img · 2025-08-07T09:26:13Z

include/aos/common/types.hpp

@@ -1586,6 +1586,17 @@ class InstanceStateType {
 using InstanceStateEnum = InstanceStateType::Enum;
 using InstanceState     = EnumStringer<InstanceStateType>;

+/**


It should be part of cloudprotocol desired status: cloudprotocol.InstanceInfo

al1img · 2025-08-07T10:40:04Z

include/aos/cm/launcher/launcher.hpp

+/**
+ * Auxiliary class to accumulate node information.
+ */
+class NodeHandler {


Move node hander and related structs to nodehandler.hpp

al1img · 2025-08-07T10:59:17Z

src/cm/launcher/instancemanager.cpp

+    }
+
+    if (auto err = RemoveOutdatedInstances(); !err.IsNone()) {
+        LOG_ERR() << "Can't remove outdated instances" << Log::Field(err);


al1img · 2025-08-07T13:41:22Z

src/cm/launcher/instancemanager.cpp

+void InstanceManager::OnServiceRemoved(const String& serviceID)
+{
+    (void)serviceID;
+    // TODO: Clarify what to do


Remove all cached instances that belong to this service, cleanup state/storage.
If there are active instances, error should be returned.

al1img · 2025-08-07T13:44:05Z

include/aos/cm/launcher/launcher.hpp

+     * @param serviceVersion version of the service.
+     * @param err Error.
+     */
+    void SetInstanceError(const InstanceIdent& id, const String& serviceVersion, const Error& err);


id -> instanceIdent

al1img · 2025-08-07T13:44:13Z

include/aos/cm/launcher/launcher.hpp

+     * @param[out] info output structure to hold instance information.
+     * @return Error.
+     */
+    Error GetInstanceInfo(const InstanceIdent& id, storage::InstanceInfo& info);


al1img · 2025-08-07T13:45:42Z

src/cm/launcher/instancemanager.cpp

+
+Error InstanceManager::UpdateInstanceCache()
+{
+    auto instances = MakeUnique<StaticArray<storage::InstanceInfo, cMaxNumInstances>>(&mAllocator);


mlohvynenko and others added 25 commits July 3, 2025 18:48

sm: common: move types common to cm & sm to common folder

2049308

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add networkmanager interface

fb51304

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add imageprovider interface

4352d1b

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add nodeinfoprovider interface

ed30d38

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add nodemanager interface

cb57da3

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add resourcemanager interface

22411af

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: add storage interface

beb0a3b

Signed-off-by: Mykola Kobets <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Solianko <[email protected]>

cm: networkmanager: extend allow con size

6730f67

Signed-off-by: Mykola Solianko <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Oleksandr Grytsov <[email protected]>

iam: common: Move cNodeMaxNum const to common types

53091b3

Signed-off-by: Mykola Kobets <[email protected]>

common: default initialize values of builtin types

318485e

Signed-off-by: Mykola Kobets <[email protected]>

common: add allowed connections to oci::ServiceConfig

5ef316f

Signed-off-by: Mykola Kobets <[email protected]>

common: add exist method to algorithms

3fab591

Signed-off-by: Mykola Kobets <[email protected]>

common: tools: add Clear method to IdentifierPool

fba7fd6

Signed-off-by: Mykola Kobets <[email protected]>

common: add run service request to common/types.hpp

aafdd55

Signed-off-by: Mykola Kobets <[email protected]>

common: fix sorting of instance identifiers

a320c8f

InstanceIdent-s should be sorted by service, then subject, then instance ind. Signed-off-by: Mykola Kobets <[email protected]>

cm: launcher: add launcher implementation

310cf80

Signed-off-by: Mykola Kobets <[email protected]>

cm: launcher: add unit tests for launcher

ad33223

Signed-off-by: Mykola Kobets <[email protected]>

mykola-kobets-epam force-pushed the launcher-impl branch from 1891ddc to ad33223 Compare July 24, 2025 16:44

al1img reviewed Aug 8, 2025

View reviewed changes

al1img force-pushed the develop branch from 2d4cc7a to 30caba6 Compare September 10, 2025 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Launcher implementation #342

Launcher implementation #342

Uh oh!

mykola-kobets-epam commented Jul 24, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

al1img Aug 7, 2025

Uh oh!

Uh oh!

Launcher implementation #342

Are you sure you want to change the base?

Launcher implementation #342

Uh oh!

Conversation

mykola-kobets-epam commented Jul 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!