Skip to content

Conversation

@al1img
Copy link
Collaborator

@al1img al1img commented Aug 28, 2025

No description provided.

mlohvynenko and others added 30 commits July 3, 2025 18:48
This patch adds a new identifier pool utility to the common
tools library.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds cloudprotocol state structures.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds storage state interfaces to the cm module.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch makes it possible to use instance ident
with STL containers that require a less operator.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds support for the SHA3-224 hash algorithm
in the crypto provider.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch enhances the platform filesystem interface
by adding a method to set user quota.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch removes the redundant definition of the SHA1 digest
size in the configuration header file.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds a new communication interface to the cm module
with API needed for storage state module.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Signed-off-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch enhances the usability of the EnumStringer class
in constant expressions.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds failed item status enum value.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch updates cloud message type enum with all
supported values.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch aligns the instance status structure with
the cloud protocol.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch defines monitoring message from the cloud protocol.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch removes redundant log message type enum
as cloud protocol message type enum contains these values.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch aligns the request log message with the cloud protocol:
- Upload options are moved out from the log filter
to the request log message;
- Log type is changed to log upload type in the upload options struct.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch adds alerts cloud message structure.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch defines a constant for the maximum number
of certificate chains.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch implements certificates cloud protocol messages.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
This patch moves the bearer token length constant
to the types header to make it more accessible.

Signed-off-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
al1img and others added 27 commits August 20, 2025 17:56
cloudprotocol::NodeConfig is changed and not compatible with current
resourcemanger implementation. resourcemanger should be reimplemented but to
make it compile and to do not break unit tests, use own NodeConfig struct for
now.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Move AOS_CONFIG_NETWORKMANAGER_CONNECTIONS_PER_INSTANCE_MAX_COUNT to CM config.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
`clean` now means: clean build artifacts before build.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
`build-type` option allows to choose `Release`, `Debug`, `RelWithDebInfo` and
`MinSizeRel` build type.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
As we don't use dynamic memory allocation, we need more stack for local
variables.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Solianko <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Solianko <[email protected]>
Reviewed-by: Oleksandr Grytsov <[email protected]>
Reviewed-by: Mykola Kobets <[email protected]>
We agreed with cloud to have different struct for desired node state and in
desired status and node status in unit status.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Align NodeStatus enum with cloud protocol.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Remove parent BaseState class with message type and use instance ident directly
in each state message.

Signed-off-by: Oleksandr Grytsov <[email protected]>
Use String instead of StaticString in StringToUUID and return error instead of
assert.

Signed-off-by: Oleksandr Grytsov <[email protected]>
This field is optional by design.

Signed-off-by: Oleksandr Grytsov <[email protected]>
These folders are removed in new project structure.

Signed-off-by: Oleksandr Grytsov <[email protected]>
@al1img al1img closed this Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 89.02439% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.17%. Comparing base (547591b) to head (a5129be).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/core/sm/launcher/launcher.cpp 11.76% 15 Missing ⚠️
src/core/common/tools/uuid.cpp 57.14% 3 Missing ⚠️
src/core/common/cloudprotocol/desiredstatus.hpp 0.00% 2 Missing ⚠️
src/core/common/tools/identifierpool.hpp 93.93% 2 Missing ⚠️
src/core/sm/launcher/instance.cpp 77.77% 2 Missing ⚠️
src/core/common/crypto/mbedtls/cryptoprovider.cpp 50.00% 1 Missing ⚠️
src/core/common/monitoring/resourcemonitor.cpp 96.66% 1 Missing ⚠️
src/core/common/ocispec/runtimespec.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   82.22%   82.17%   -0.06%     
==========================================
  Files         169      171       +2     
  Lines       17267    17046     -221     
  Branches     2323     2319       -4     
==========================================
- Hits        14198    14007     -191     
+ Misses       3069     3039      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
45.0% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants