Nodeinfoprovider #370
Merged
Nodeinfoprovider #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al1img
force-pushed
the
nodeinfoprovider
branch
from
f6e06ed to
b40fb06
Compare
MykolaSuperman
approved these changes
Sep 20, 2025
mlohvynenko
reviewed
Sep 22, 2025
| { | ||
| return mNodeID == status.mNodeID && mResources == status.mResources && mRuntimes == status.mRuntimes; | ||
| } | ||
| /** |
mlohvynenko
approved these changes
Sep 22, 2025
mykola-kobets-epam
approved these changes
Sep 22, 2025
| # Node info provider | ||
|
|
||
| Provides node information. Since node information is collected from two sources: IAM and SM, this module collects, | ||
| combines and provides combined node information for other CM modules. |
There was a problem hiding this comment.
I would suggest replace:
module collects, combines and provides combined
with
provides combined
al1img
force-pushed
the
nodeinfoprovider
branch
2 times, most recently
from
b183a48 to
0fcf0ae
Compare
Signed-off-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]>
Fix fix header guard in nodeinfoprovider.hpp and move GetAllNodeIds method at first place. Signed-off-by: Oleksandr Grytsov <[email protected]> Reviewed-by: Mykola Kobets <[email protected]> Reviewed-by: Mykola Solianko <[email protected]> Reviewed-by: Mykhailo Lohvynenko <[email protected]>
al1img
force-pushed
the
nodeinfoprovider
branch
from
0fcf0ae to
c69ad06
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature_unification #370 +/- ##
====================================================
Coverage 81.44% 81.44%
====================================================
Files 179 179
Lines 17231 17231
Branches 2320 2320
====================================================
Hits 14034 14034
Misses 3197 3197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.