Update cloud protocol #373
Open
+2,791
−2,363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-kobets-epam
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
common: tools: crate core alert structs
=> create
| ResourceInfoStaticArray mResources; | ||
| RuntimeInfoStaticArray mRuntimes; | ||
| ResourceInfoArray mResources; | ||
| RuntimeInfoArray mRuntimes; |
There was a problem hiding this comment.
I would remove Array suffix as well, eg:
ResourceInfoArary => Resources,
RuntimeInfoArray => Runtimes
MykolaSuperman
approved these changes
Sep 24, 2025
mlohvynenko
approved these changes
Sep 24, 2025
al1img
force-pushed
the
update_cloud_protocol
branch
from
95ed5c5 to
db9424b
Compare
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
update_cloud_protocol
branch
from
db9424b to
f8126ae
Compare
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Move common part to types and use local env vars struct in core lib. Signed-off-by: Oleksandr Grytsov <[email protected]>
Move common part to types and use local log struct in core lib. Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
update_cloud_protocol
branch
from
2e4e3dd to
11107b4
Compare
mlohvynenko
reviewed
Sep 29, 2025
| struct SystemQuotaAlert : AlertItem { | ||
| Identity mNode; | ||
| StaticString<cAlertParameterLen> mParameter; | ||
| size_t mValue; |
There was a problem hiding this comment.
Suggested change
| size_t mValue; | |
| size_t mValue{}; |
mlohvynenko
reviewed
Sep 29, 2025
| */ | ||
| struct InstanceQuotaAlert : AlertItem, InstanceIdent { | ||
| StaticString<cAlertParameterLen> mParameter; | ||
| size_t mValue; |
There was a problem hiding this comment.
Suggested change
| size_t mValue; | |
| size_t mValue{}; |
mlohvynenko
reviewed
Sep 29, 2025
src/core/cm/cloudprotocol/alerts.hpp
Outdated
| */ | ||
| struct DownloadAlert : AlertItem { | ||
| StaticString<cIDLen> mImageID; | ||
| size_t mDownloadedBytes; |
There was a problem hiding this comment.
Suggested change
| size_t mDownloadedBytes; | |
| size_t mDownloadedBytes{}; | |
| size_t mTotalBytes{}; |
mlohvynenko
reviewed
Sep 29, 2025
| Optional<AlertRules> mAlertRules; | ||
| Optional<ResourceRatios> mResourceRatios; | ||
| StaticArray<StaticString<cLabelNameLen>, cMaxNumNodeLabels> mLabels; | ||
| uint64_t mPriority {0}; |
There was a problem hiding this comment.
Quite an optional comment, should discuss with team:
Suggested change
| uint64_t mPriority {0}; | |
| uint64_t mPriority {}; |
Currently we have the next POD initialization approaches:
- uint64_t mPriority {};
- uint64_t mPriority {0};
- uint64_t mPriority = 0;
- uint64_t mPriority ; // trash - initialized
It seems to me the 1st one approach is the most used
mlohvynenko
reviewed
Sep 29, 2025
| struct InstanceInfo { | ||
| Identity mIdentity; | ||
| Identity mSubject; | ||
| uint64_t mPriority {0}; |
There was a problem hiding this comment.
ditto (the same very optional comment)
mlohvynenko
reviewed
Sep 29, 2025
| struct PushLog { | ||
| StaticString<cLogIDLen> mLogID; | ||
| Identity mNode; | ||
| uint64_t mPartsCount; |
There was a problem hiding this comment.
Suggested change
| uint64_t mPartsCount; | |
| uint64_t mPartsCount{}; |
mlohvynenko
reviewed
Sep 29, 2025
| StaticString<cLogIDLen> mLogID; | ||
| Identity mNode; | ||
| uint64_t mPartsCount; | ||
| uint64_t mPart; |
There was a problem hiding this comment.
Suggested change
| uint64_t mPart; | |
| uint64_t mPart{}; |
mlohvynenko
reviewed
Sep 29, 2025
| */ | ||
| struct NodeStateInfo { | ||
| Time mTimestamp {}; | ||
| bool mProvisioned = false; |
There was a problem hiding this comment.
Suggested change
| bool mProvisioned = false; | |
| bool mProvisioned {}; |
mlohvynenko
reviewed
Sep 29, 2025
| ResourceInfoArray mResources; | ||
| RuntimeInfoArray mRuntimes; | ||
| NodeAttributeArray mAttrs; | ||
| bool mProvisioned = false; |
There was a problem hiding this comment.
Suggested change
| bool mProvisioned = false; | |
| bool mProvisioned {}; |
mlohvynenko
reviewed
Sep 29, 2025
| struct PushLog { | ||
| StaticString<cLogIDLen> mLogID; | ||
| StaticString<cNodeIDLen> mNodeID; | ||
| uint64_t mPartsCount; |
There was a problem hiding this comment.
Suggested change
| uint64_t mPartsCount; | |
| uint64_t mPartsCount{}; |
mlohvynenko
reviewed
Sep 29, 2025
| StaticString<cLogIDLen> mLogID; | ||
| StaticString<cNodeIDLen> mNodeID; | ||
| uint64_t mPartsCount; | ||
| uint64_t mPart; |
There was a problem hiding this comment.
Suggested change
| uint64_t mPart; | |
| uint64_t mPart{}; |
mlohvynenko
approved these changes
Sep 29, 2025
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
Signed-off-by: Oleksandr Grytsov <[email protected]>
al1img
force-pushed
the
update_cloud_protocol
branch
from
11107b4 to
d08416f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.